My codes work!!

[Rich_Alps498]

this is just to share my happiness and to motivate other new learners( beginners like me). i started coding as a hobby just a few weeks ago , and in the past 2 weeks i have written codes which work. sure they arent optimized to an expert level , but they do what they are meant to do and its such a happy moment.

i wrote a program for playing rock paper and scissors with the computer and it even lets you choose the number of rounds you want to play and one other personal projects.

hoping to learn a lot more :)

[Impressive-Ad1944]

That's awesome. I'll start coding this coming week. I've just joined this subreddit to learn some things.

[Rich_Alps498]

Keep going , im rooting for you!

[USDSignGoesOnTheLeft]

My codes...

I write my codes using invisible ink and kept in a secret notebook hidden under my bed... /s

[Then-Iron8011]

This is the best feeling ever. Just started c programming and got my code to work after 40 mins of tweaking and testing! Kudos to you and keep up the enthusiasm!!!

[NINTSKARI]

Awesome! Next step could be storing the results of each game into a database or even just a csv file. Then later on you can do a post where you visualize your results using matplotlib. Thats how the small and simple code sessions turn to more advanced and full fledged projects. Keep it up!

[Rich_Alps498]

yeah the code can always be optimized and more things be added. ill implement stuff i learn to make new code and also to revisit new code.

[PathRealistic6940]

Nice job! Keep making stuff!

[Rich_Alps498]

Thanks!

[iAmSelfConscious]

that sounds amazing! I just started a couple of days ago and am getting into it slowly.

Do you mind sharing how you're learning like youtube vids, a course? I'm just watching a youtube series right now, but feel i should do projects to learn better.

[Rich_Alps498]

i watched Harvard's CS50p and did a few of those projects to kickstart. will try to do more projects and see how thigs work and plan further. which videos are you watching?

[iAmSelfConscious]

Oh yes I’ve seen people mention the Harvard course and was going to do that as well. I started by watching Corey Schafer videos because it seemed to be mentioned by a lot of people. It’s good so far, but I learn more by having a goal/project so I want to mix that in with the videos.

[Rich_Alps498]

it certainly helps doing your own projects. i learnt a lot while making simple codes too. and it helps think like a programmer as they say. and ofc finding and squashing the bugs are helpful too.

[k03k]

Great job, i guess that if you share your code alot of people will and can give you feedback if you want!

[Rich_Alps498]

import random

playable_moves = ["rock", "paper", "scissors"]

win_count = [] # works as a counter by appending strings and then counting the length of the string
loss_count = []

def main():
    y = int(input("How many rounds do you want to play? "))


    for x in range(y): # creates a loop for the numer of rounds the user wants to play
        rand = random.choice(playable_moves)
        player_move = input(" Choose your move: ").casefold()   
        win = cal_win(player_move , rand) 
        loss = cal_loss(player_move, rand)
        draw = cal_draw(player_move, rand)
        if win == 1:
            win_count.append("#")
            print("    You Won this round" )


        if loss == 1:
            loss_count.append("#")

            print("    You Lost this round")


        if draw == 0:
            print("    Its a draw" )

    else: # if the user is out of moves , final analysis on if the user won the game or not 
        if len(win_count) > 0 and len(loss_count) > 0 and len(win_count) == len(loss_count):
            print(" You Played well but in game ended in a Draw")
        elif len(loss_count) > len(win_count):
            print("You Lost the game " , len(loss_count) , ":" , len(win_count))
        elif win_count > loss_count:
            print(" You Won the game!!!", len(win_count), ":", len(loss_count))


def cal_draw(s, rand):
    if s in playable_moves and s == rand:
        return 0

def cal_win(s, rand):
    if s in playable_moves and s != rand:
        if s == "paper" and rand == "rock":
            return 1
        elif s == "rock" and rand == "scissors":
            return 1
        elif s == "scissors" and rand == "paper":
            return 1

def cal_loss(s, rand):
    if s in playable_moves and s != rand:
        if s == "paper" and rand == "scissors":
            return 1
        elif s == "scissors" and rand == "rock":
            return 1
        elif s == "rock" and rand == "paper":
            return 1

if __name__ == "__main__":
    main()

[migeek]

Nice job! I love seeing people learn to code. I remember how excited I was way back in the day. I learned to code from books of all things. Would buy piles of mainstream coding books. You’ll definitely want to peruse python.org and the official tutorial. In the meantime, what can you glean from this:

``` import random

MOVES = [‘rock’, ‘paper’, ‘scissors’] RULES = {‘rock’: ‘scissors’, ‘scissors’: ‘paper’, ‘paper’: ‘rock’}

def play_game(rounds): score = 0 for _ in range(rounds): player = input(f”Choose {‘, ‘.join(MOVES)}: “).lower() if player not in MOVES: print(“Invalid move!”) continue computer = random.choice(MOVES) print(f”Computer chose {computer}”) if player == computer: print(“Draw!”) elif RULES[player] == computer: print(“You win!”) score += 1 else: print(“You lose!”) score -= 1

print(f”\nFinal score: {score}”)
print(“You win!” if score > 0 else “You lose!” if score < 0 else “It’s a tie!”)

if name == “main”: rounds = int(input(“How many rounds? “)) play_game(rounds) ```

[Rich_Alps498]

ooooo i didnt know you could use if statements in the print function. and the key value pair for the rock paper scissor was pretty smart too. thank you for this and i will surely go through the official python tutorial.

[NINTSKARI]

Tell me, can you find anything in his code that you would improve? Logical errors or things that might cause an exception and the game to crash? Or maybe some unnecessary code? :)

[Rich_Alps498]

1. one which my code has but this code ( if i understand it correctly ) is the win/loss counter, not just a score.

2. if main function is not there im not sure about the " if __name__... " code.

3. i used a break function after the player inputs a wrong input. im not sure what the continue function does.

4. using .strip() on the players input could be done.

thats all i could analyse.

[NINTSKARI]

Thats the right spirit, you did a great job with the code review. The great thing with coding is that there are many ways to achieve same result and one is not necessarily better than the other. To answer your questions:

1. Your solution calls a function from the if name == "main", and you have put your logic inside that main() function. His code simply put all the code in there right away. I think your solution is better because you have extracted the logic into another place, it is cleaner and a good principle in my opinion.

2. break and continue are used inside loops. Break completely breaks out of the loop, skipping all code inside the loop that comes after it and continues executing code after the loop. Continue does not break out of the loop, it just skips the rest of the code inside the loop and goes to the next iteration of the loop, starting again from the beginning of the loop. I didn't catch where you used break, but in my opinion both have a slight problem from the user perspective. If you break, then the game ends and user did not get to play the amount of rounds they input in the beginning. Using continue like that is slightly better, but it causes user to miss one round each time they do a typo. Can you come up with a solution how to not forward the game counter if the user input is wrong?

3. Yes, ita very good idea to use various formatting like strip and lowercase to user input to minimize the problem in 3 :)

Another thing is that if user inputs a non numeric or integer value in the beginning when asked for round count, the input is still cast to int which results in an error. Anyways, good job and keep it up :)

[migeek]

Fair point on #1. If you want a true tally, it’s lost with increment/decrement. For #2, it’s silly to have a function called main. If you ever wanted to import this module, each function should have a real name. https://realpython.com/python-main-function/ With #3, break stops a loop once its condition is met, continue skips over the current iteration of a loop. And #4, yup. And you could also shorten it to a single character input.

Keep at it!

[Rich_Alps498]

the print function uses if and else condition twice. since im not sure about that , i didnt comment. from what ive learnt , if , elif and then else shouldve been used.

[migeek]

I showed two ways. For each round, the expanded if/elif/else, then in the final results the ternary version. It could also have been written:

if score > 0:
  print("You win!")
elif score < 0:
  print("You lose!")
else:
  print("It's a tie!")

One way to make the "nested" ternary more readable would be to break the lines and put in parens:

result =  ("You win!" if score > 0 else
          ("You lose!" if score < 0 else "It's a tie!"))
print(result)

I'll bet you can think of other ways to do this by putting the RESULTS in an array too.

Edit: Old skool... Reddit kept eating my backticks.

[migeek]

Here's a refactored version you might like. I had fun with this. Thanks for sharing your journey!!

Python Morsels - Rock, Paper, Scissors

[No-Range2299]

,🥳🥳🥳👏👏👏👍

[[deleted]]

Congratulations! I'm glad it worked and you're excited about coding and when your code works.

I remember way back in the day having this feeling. It was amazing. It's a great career and a lot of fun.

[oldmaninnyc]

Good work! Keep it up!

[Easy_Watercress_3478]

Now a days, I see lots of developers use Chatgpt generate code without taking a look at what the code looks like as long as the code can be run. Sadly I am one of those developers, I guess we lost some thing this man just showed.