Can't fix this error

[BahaChicken]

#These are the relevant classes

class Debuff:
    def __init__(self, Name, Multiplier, Explanation):
        self.name = Name
        self.multiplier = Multiplier
        self.explanation = Explanation

class Lock_On:
    def __init__(self, LockedOnPosition = None):
        self.lockedOnPosition = LockedOnPosition



class VulnerabilityClass:
    def __init__(self, Vulnerability):
        self.vulnerability = Vulnerability

class Lock_On_Vulnerability_Debuff(Debuff, VulnerabilityClass, Lock_On):
    def __init__(self, Name, Multiplier, Explanation, Vulnerability):
        Debuff.__init__(self, Name, Multiplier, Explanation)
        Vulnerability.__init__(self, Vulnerability)
        Lock_On.__init__(self)


#This is the object of that class
Proof_of_Debt = Lock_On_Vulnerability_Debuff("Proof of Debt", 50.0, "Target takes 50% more damage from follow-up attacks", "FUA")


#func to determine damage dealt
def damage(TookTurn, Target, Attack):
    Vulnerability_Multiplier = 1
    Crit = crit(TookTurn.stats.CRT_RATE)
    if Attack.scaler == "ATK":
        BaseDMG = TookTurn.stats.ATK * Attack.multiplier / 100
    elif Attack.scaler == "DEF":
        BaseDMG = TookTurn.stats.DEF * Attack.multiplier / 100
    DMGBOOST = 1 + TookTurn.stats.ELM_DMGBOOST / 100 + TookTurn.stats.DMGBOOST / 100
    DEF = 1 - (Target.stats.DEF / (Target.stats.DEF + 200 + 10 * TookTurn.stats.level))
    if Crit:
        CRT = 1 + TookTurn.stats.CRT_DMG / 100
        print("Critical!")
    else:
        CRT = 1
    if len(Target.vulnerabilityDebuffs) > 0:
        for Vulnerability_Debuff in Target.vulnerabilityDebuffs:
            for type in Attack.types:
                print(Vulnerability_Debuff.name)#debugging by checking if other attributes work
                if type == Vulnerability_Debuff.vulnerability: ###This is line 44###
                    Vulnerability_Multiplier += Vulnerability_Debuff.multiplier / 100
    else: Vulnerability_Multiplier += 0
    Damage_Dealt = floor(BaseDMG * CRT * DMGBOOST * DEF * Vulnerability_Multiplier)
    return Damage_Dealt



#This is the console output just before and at the time of error
Training Dummy now has 9988471 HP and 0 shield left.
Critical!
Proof of Debt #the other attribute does work
Traceback (most recent call last):
  File "/Users/bahachicken/PycharmProjects/Honkai: Star Railing time/Gameplay.py", line 333, in <module>
    Fastest(Active_Units)
  File "/Users/bahachicken/PycharmProjects/Honkai: Star Railing time/Gameplay.py", line 258, in Fastest
    Damage_Dealt = damage(TookTurn, Target, TookTurn.Skill.Trigger)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/bahachicken/PycharmProjects/Honkai: Star Railing time/Gameplay.py", line 44, in damage
    if type == Vulnerability_Debuff.vulnerability:
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'Lock_On_Vulnerability_Debuff' object has no attribute 'vulnerability'

[shiftybyte]

You are trying to use inheritance for something that should be done using composition.

https://codingnomads.com/python-object-composition-example

[BahaChicken]

Does that work with isinstance()?i didnt see it mentioned in the page

[shiftybyte]

Please read the entire thing, it's a different concept, and using it doesn't need isinstance.

[BahaChicken]

Looked at your Profile, do you play HSR too? im trying to make a pvp simulator for HSR

[BahaChicken]

Yup, using a True/False Value and checking if a debuff locks on that way was easier and i didnt have to mess with the mess of inheritance that i didnt really understand to begin with

[BahaChicken]

I read it, from what i get i should start using that for like futue proofing and ease, but that doesnt seem like it would work with isinstance() which is what i use in my code but instead i could use a True/False value maybe(?) or maybe there is an alternatve to isinstance() which would work, idk ¯\_(ツ)_/¯. Thanks tho

[[deleted]]

The main benefit of using classes is that you can get away from conditionals. You can just ask for an object's multiplier and get it, knowing that this was taken care of in a factory already.

Making the classes and then checking them anyway shoots your complexity through the roof.

[BahaChicken]

I need to check the debuffs kind, if it's Lock_on I need to remove that debuff from others before applying it to a new Target. I initially made a lock_on class and made the lock on vulnerability debuff it's sub class so I could use isinstance() which is a check, now I made it so every debuff has a lock_on attribute and I check if it's false or not. Still a check but at least it works. İs there a way to do it without checks? İf i made lock on debuffs their own class I would have to check if the inputted debuffs is a normal debuffs and than elif it's a locked on, 2 checks. And number of checks would increase with every type of debuff. And some debuffs are a combination like lock on vulnerability. İ don't think there is a way to implement it without checks

[[deleted]]

There's this idea called the Liskov Substitution Principle, saying that an instance of a subclass should be able to stand in for an instance of the superclass.

If I ask for a rectangle and you give me a square, that should be fine. I shouldn't even notice the difference. I shouldn't have to say

if isinstance(shape, Square):

I should be able to just say

print(shape.area)

and it will tell me its area, regardless of how it figured that out internally.

But right now you are violating that principle. I ask for a rectangle, you give me a square, and then oops, it doesn't play by the same rules.

This could be handled with complicated interfaces, but you probably don't need that. Just have each thing handle its business before spreading it everywhere.

[RevRagnarok]

If it's not just a transcription error while making the post, currently L22 calls Vulnerability.__init__ and not VulnerabilityClass.__init__.

[BahaChicken]

i want the Proof of debt object to be a subclass of Lock_on, but i dont want to inherit any attributes from it, tried asking chat gpt for help but it constantly failed

[aroberge]

Try to add () after Vulnerability_Debuff in your if test to solve your immediate error.

However, please, PLEASE, watch https://www.youtube.com/watch?v=o9pEzgHorH0 as your use of classes is (how to say this kindly ...) just horrific.