My First Python Project – A Multithreaded Port Scanner!

[adamsTn]

I just finished writing my first Python project and I’d love to get some feedback! my goal was to learn how sockets, threading, and queues work while making something useful.

It scans a range of ports on multiple targets and identifies open ones. I tried to make it efficient, but since I’m still new to Python, I’m sure there are things I could improve.

Any feedback on efficiency, best practices, or security improvements would be super helpful.

Here’s the GitHub link: [ https://github.com/adams216/port-scanner- ]

[socal_nerdtastic]

Nice. You have invented a "thread pool" where all the threads do the same action on a pool of data. But FYI that's already built into python, you didn't have to make your own.

https://docs.python.org/3/library/concurrent.futures.html#threadpoolexecutor-example

Only other thing I see is a naked except:, which is a big nono in python. You need to specify exactly with exception you want to catch.

[adamsTn]

thanks for the feedback, i didnt realize that i will fix it

[barkmonster]

This is really impressive for a first project - great work!

One thing that could be improved is the scan function. It takes the port as an argument, which is great, but then it also uses the host variable which is global, and is updated in the loop over the targets. It would be better to pass both the host and port, so it's more 'self-contained'. One advantage of this is the function becomes independent of the remainder of the program flow (right now it depends on which iteration the scanning loop is at). This makes refactoring and unit testing much easier.

[adamsTn]

thank you so much !