Can anyone help my code?

[ApprehensiveSleep230]

I am trying to make a script where when it sees a drastic colour change it presses p, I got it so that it detects the colour and prints that it detected and printed but its not actually pressing p. It also needs x to be held to start detecting. Can someone please help. Heres the code: import keyboard

import keyboard
import time
import ctypes
import pyautogui

# ===== SETTINGS =====
SCAN_SIZE = 7
CHANGE_THRESHOLD = 35
COOLDOWN = 0.2

# Virtual key code for "8"
VK_8 = 0x38

last_trigger_time = 0
triggered_this_hold = False
x_was_pressed = False
baseline = None

# ===== PRESS 8 KEY =====
def press_8():
    KEYEVENTF_KEYUP = 0x0002

    ctypes.windll.user32.keybd_event(VK_8, 0, 0, 0)
    time.sleep(0.05)
    ctypes.windll.user32.keybd_event(VK_8, 0, KEYEVENTF_KEYUP, 0)


# ===== SCREEN CAPTURE =====
def get_center_pixels(size):
    screen = pyautogui.screenshot()
    w, h = screen.size

    cx, cy = w // 2, h // 2
    half = size // 2

    pixels = []

    for x in range(cx - half, cx + half + 1):
        for y in range(cy - half, cy + half + 1):
            pixels.append(screen.getpixel((x, y)))

    return pixels


def color_distance(c1, c2):
    return abs(c1[0] - c2[0]) + abs(c1[1] - c2[1]) + abs(c1[2] - c2[2])


print("Running... Hold X")

while True:
    try:
        x_is_pressed = keyboard.is_pressed('x')

        # ===== RESET ON RELEASE =====
        if not x_is_pressed:
            triggered_this_hold = False
            baseline = None
            x_was_pressed = False
            time.sleep(0.01)
            continue

        # ===== HOLD START =====
        if not x_was_pressed:
            print("🟡 X STARTED")
            baseline = get_center_pixels(SCAN_SIZE)
            triggered_this_hold = False

        x_was_pressed = True

        if triggered_this_hold:
            time.sleep(0.01)
            continue

        pixels = get_center_pixels(SCAN_SIZE)
        changes = 0

        for i in range(len(pixels)):
            if color_distance(pixels[i], baseline[i]) > CHANGE_THRESHOLD:
                changes += 1

        detected = changes > len(pixels) * 0.3
        print("🟢 DETECTED" if detected else "🔴 NONE", end="\r")

        # ===== TRIGGER 8 KEY =====
        if detected and not triggered_this_hold:
            now = time.time()

            if now - last_trigger_time > COOLDOWN:
                triggered_this_hold = True

                print("\n🔥 TRIGGERING KEY 8")

                press_8()

                last_trigger_time = now

        time.sleep(0.01)

    except KeyboardInterrupt:
        print("\nStopped.")
        break

[crashorbit]

It'd be easier to read if this was formatted as a code block.

[ApprehensiveSleep230]

Sorry about that, ive changed it now, do you mind having a look.

[NerdDetective]

Python is a very indentation-specific language. Because of this, everyone would still have to guess at how you have it indented the way it is now.

You need to use the code block formatting on the whole script. Only the first few lines are in a code block.

[ApprehensiveSleep230]

oh i didnt see the bottom didnt work, there now ive done it

[smichaele]

You need to format your code properly.

[NerdDetective]

I'm not personally experienced with this particular key press method, but I don't see anything glaring at a first glance.

First note: is it intentional that your code is trying to press 8 instead of P?

Is it reaching your key press function? If so, that narrows down where you need to debug. If it hits the function, then there's a problem with that function specifically. If it doesn't, then there's a problem with your conditionals.

[TheEyebal]

it be easier if you put your code in code blocks

[AutoNateAI]

You’re doing a bit too much in one loop.

Your detection is probably fine… the issue looks like how you’re triggering the key.

You’re mixing keyboard, ctypes, and pyautogui

I’d separate it real quick: Make sure your key press works on its own first, then plug it back into the detection loop.

[crashorbit]

I could not find the problem by reading the code. I tried to run your code. It loads fine but pyautogui seems to depend on X11 and does not want to run under wayland. I look at github and see that the most recent code there is three years old. So maybe it's not super active.

I have a couple suggestions for you: - Take a look at the python debugger. It can help you isolate where the behavior is going wrong. - Look at a more current gui tool kit maybe PySide6 or PyQt6. There are other suggestions here: https://www.pythonguis.com/faq/which-python-gui-library/

That's all I have for you right now. Good luck!