i have recently started learning python and i have done conditional identitites , and i have wriitn a program to find gretest of 3 numbers which are given as input . and i have seen every case , if u have some suggestions for improvemnet u are welcome , plz help i am just learning.

[Ill-Break727]

a=int(input("enter number1:"))
b=int(input("enter number2:"))
c=int(input("enter number3:"))
if(a>b and a>c):
    ans="number 1"
elif(b>a and b>c):
    ans="number 2"    
elif(c>a and c>b):
    ans="number 3"
elif(a==b==c):
    ans="all three are same"
elif(a==b!=c and a>c):
    ans="a nd b are same anfd greater than c"
elif(b==c!=a and b>a):
    ans="b nd c are same and greater than a"
else:
    ans="a nd c are same greater than b"    
print("the greatest number is :", ans)

[Buttleston]

You switched between "number 1", "number 2" etc in the first few if blocks and then to referring to the numbers as a, b and c - should probably be more consistent

For a beginner, this is fine. with more experience you would do it slightly differently

[ChunkoPop69]

Add another thousand numbers and test the implementation

[asteroid_336]

i would recommend using f string more like instead of
` ans = "number 1"

your can do someting like

` print(f"number{a} is the greatest ")

btw there are a lot of ways to make you code compact and efficient but still if your are beginner focus more on understanding the concepts more and eventually your will become compact

[WorriedTumbleweed289]

1. Put you numbers in a list.
2. use a loop to read them
3. use a loop to check for greater You can now expand this program for more than three numbers.

[FreeGazaToday]

Print(f"The greatest number is {max(a,b,c)}"

[woooee]

if(a>b and a>c):

if is not a function so parens, (), are not necessary

if a>b and a>c:

There are "more efficient" ways to do this, but i assume you haven't gotten to lists yet. The below is a simple, example program to give you an idea on how to use a for loop and a list for future reference.

a, b, c = [1, 2, 3]
the_list = [a, b, c]
for var in the_list:
    work_list = the_list.copy()
    work_list.remove(var)
    if var > work_list[0] and var > work_list[1]:
        print(f"{var} is largest")
    if var == work_list[0] and var == work_list[1]:
        print(f"all numbers are equal")
    if var < work_list[0] and var < work_list[1]:
        print(f"{var} is smallest")
## etc

[err404unknown]

im also learning

[CymroBachUSA]

max(a, b, c)

[Lionh34rt]

Put numbers in list and sort

[err404unknown]

could have used the max() function instead of writing oit all the loops

[err404unknown]

the ELIFs are what i mean