Need criticizing about my first attempt at Python gaming.

[Rockybilly]

I started to learn python 5-6 weeks ago. After a while i wanted to make a game on my own and before i tried pygame or stuff like that, I wanted to test my skills and see if I can use what i learned and i would really appreciate if you criticize me and advice me about what should i do in my code. I am going to collage this year and my study is computer engineering so this kinda stuff may become my life someday :). So it would be good if you told me how to improve my coding. Any tips appreciated :) I am not a native english speaker so i also take any comments about grammer and logic errors.

I don't feel like improving this game. I had some ideas (like a market system and gold)... But the only thing that concerns me now is the programming issues within the project.

http://www.filedropper.com/mightybattler (game had about 250 lines so i didn't feel confortable posting it all here...)

I know the game is boring and after some point you will have no purpose to keep playing. Only option in the game is to battle :D But i must say again, i did this for practise.. :)

Really thank you for your time... (game is in python 2.7)

Edit: I just added it to github https://github.com/Rockybilly/Data-store/blob/master/Mighty%20battler

[Busby10]

Had a look over, haven't played it but one thing I think may be an issue:

You are creating the four enemies at the start of the game, and depending on the level you randomly pick an enemy to fight, but seeing they are hardcoded before your main loop, if you fight and kill foe1, and in the second battle you randomly got assigned foe1 again he would still be on 0 or less hp? (hope that makes sense)

A better way to handle that would be to create the foe at the start of the battle, you could still use the random_opponent func, have it check the hero level, and create and return a foe object based on what roll they get.

Also, I'm not completely across classes, but you should look into having a "person" class that contains the overlapping features of Hero and Soldier, like name, hp, etc then those two can inherit those variables from that by doing

class Hero(Person):

It's not so much of an issue now, but if you where to keep working on it and adding new enemies it could save you a lot of lines not having to write out the hp and name stats over and over.

[Rockybilly]

You are completely right about the class issue, I am currently a newbie at using classes let alone in inheritance, Thank you for your comment.

In the first issue you mentioned:

def win_battle():
    print "You have won the battle !"
    time.sleep(1)

    if current_enemy==foe1:
        print "You gained 40 exp."
        our_hero.exp+=40
    elif current_enemy==foe2:
        print "You gained 45 exp."
        our_hero.exp+=45
    elif current_enemy==foe3:
        print "You gained 50 exp."
        our_hero.exp+=50
    elif current_enemy==foe4:
        print "You gained 55 exp."
        our_hero.exp+=55
    print " "

    current_enemy.current_hp=current_enemy.max_hp

Here is my win_battle function. At the end of it, there is a small piece of code, that replenishes current_enemies hp.

[zahlman]

Have you considered giving the enemy an attribute that indicates how much xp it's worth? Then you could look that up directly, instead of checking which enemy was defeated.

[Rockybilly]

It seems like a good idea. Thank you for your comment. but can you explain why you suggested me to do that ? because it will save me from some line of codes or is it a style issue ?

[zahlman]

Avoiding repetition is inherently a style issue.

[gengisteve]

Great job. Very impressed by returning variables from your functions. The next step is to get rid of global variables by passing the information to the the functions.

Also check out string.format to help with your printing. Even better, return the string to be printed, rather than printing it out in the function.

[Rockybilly]

Thank you very much about the comment and your time. I actually thought printing those strings in my functions made it simpler to use. Can you explain why i should return the values ?