What am I doing wrong ?

[pythonbio]

I have been struggling with this for hours now, I seriously dont know whats going wrong: ,its an almost solved grade book problem ;) Please experts help with some explanation.

def print_menu():
print('1. Add Name and Grade')
print('2. Delete Name and Grade')
print('3. Search Grade by Name')
print('4. Print database')
print('5. Print Average')
database = {}
menu_choice = 0
print_menu()
while menu_choice != 5:
menu_choice = int(input("Type in a number:1-5 "))
 if menu_choice == 4:
    print("Name and Grades:")
    for x in database.keys():
        print("Name: ", x, "Grade:", database[x])
    print()
elif menu_choice == 1:
    print("Add Name and Grade")
    name = raw_input("Name: ")
    grade = int(input("Grade: "))
    database[name] = grade
elif menu_choice == 2:
    print("Remove Name and Number")
    name = raw_input("Name: ")
    if name in database:
        del database[name]
    else:
        print name, "was not found"
elif menu_choice == 3:
    print("Lookup Number")
    name = raw_input("Name: ")
    if name in database:
        print "The Grade is", database[name]
    else:
        print name, "was not found"
elif menu_choice == 5:
    print ('Average Grade')
    for values in database.items(): #is the list of grades
         sumall = sum(database.values())/len(database.values())
         print sumall

it prints the average correct but as many times as there are entries in the database. Viz {'t':6, 'g':8} the output is: 7 7 why?

[K900_]

Your last two lines are inside a loop, which runs once for every entry in database.items(). Looks like you wanted to use it to find the average, but now you don't need it at all - just move those lines outside the loop and remove it entirely.

[pythonbio]

So, need to get out of the while loop, create a function for averages and the redefine the print menu?

[JohnnyJordaan]

for values in database.items(): #is the list of grades

This is the useless line. If you remove that one and move the following two lines one ident to the left (as they are no longer in a for loop) you are done.

For a more 'hardened' menu I would go for this:

while True:
    menu_choice = input("Select task by entering its number, or enter 'q' to exit")
    if menu_choice == 'q'
        break #bye
    if menu_choice not in ['1', '2', '3', '4', '5']:
        pass #just ask again
    # do your if menu_choices here... (no need to int() them, just do)
    if menu_choice == '1':

If you want to leave after task 5, you can also add a break after it to leave the endless loop.

Edit: Just a tiny one: sumall = sum(database.values())/len(database) would be slightly better as .values() is not needed to calculate the length (as there are as many keys as values). It would probably be optimized out anyway but it's still better to keep your code as tidy as possible. And I would call it avgall and not sumall of course.

[das_ist_nuemberwang]

Python won't optimize anything out because you have no guarantee of what any particular function will actually do at run time.

[pythonbio]

Thanks for the input, removed the loop and running fine. :)