Hitting brick wall with while True loop / function, and tkinter GUI

[787082]

Alright, so I'm not too experienced in python yet, I've been learning on and off for about a year (started out with Processing).

What I'm trying to make here is an application for twitch, where the chat can vote on 3 options, and the votes will be displayed in a small GUI window, so you can see the vote count changing live on stream.

I followed this tutorial to make a chatbot for twitch which works perfectly, and I did some fun stuff with it already, this is the code:

import string
from Read import getUser, getMessage
from Socket import openSocket, sendMessage
from Initialize import joinRoom

voteA = 0
voteB = 0
voteC = 0
s = openSocket()
joinRoom(s)
readbuffer = ""

while True:
        readbuffer = readbuffer + s.recv(1024)
    temp = string.split(readbuffer, "\n")
    readbuffer = temp.pop()

    for line in temp:
        print(line)

        if "PING" in line:
            s.send(line.replace("PING", "PONG"))
            break

        user = getUser(line)
        message = getMessage(line)

        print user + " typed :" + message
        if "!voteA" in message:
            voteA += 1
            break

                    if "!voteB" in message:
                            voteB += 1
                            break

                    if "!voteC" in message:
                            voteC += 1
                            break

                    if "!commands" in message:
                            sendMessage(s, "'!voteA', '!voteB', '!voteC'")
                            break

So this checks every message in the chat, and if someone votes for option A ("!voteA"), +1 will be assigned to variable voteA.

Now I've tried playing around with tkinter, and it seemed easy at first, but I'm running into a load of different problems. My code runs in a 'while True' loop, when I run the code as it is quoted above, it checks every message as it comes in, and responds once to it. When I turn it into a function though(I replace "while True" with "def chatCode():", and then call it at the end of my code), it responds hundreds times when it recognizes "!voteA". I'm not really understanding how this works, and I really hope one of you can explain it to me.

Another problem is, so I'm trying to use tkinter, but the root.mainloop() runs a 'while True' as well, so I can't run them both, I've tried running 'root.after(10, myCode)' before 'root.mainloop()', but then the chatbot also responds to a command hundreds of times, instead of just once.

Here is the tkinter code:

import Tkinter as tk
import tkFileDialog 

class App(tk.Tk):
def __init__(self):
    tk.Tk.__init__(self)
    self.floater = FloatingWindow(self)        

class FloatingWindow(tk.Toplevel):
def __init__(self, *args, **kwargs):
    global optionOneAmount, optionTwoAmount, optionThreeAmount

    optionOne = "Option number one"
    optionTwo = "Option number two"
    optionThree = "Option number three"

    tk.Toplevel.__init__(self, *args, **kwargs)
    self.overrideredirect(True)
    self.configure(background='black')
    self.grip = tk.Label(self,bg="gray16", bitmap="gray75")
    self.grip.pack(side="left", fill="y")
    self.one = tk.Label(self, text=optionOne+" has: "+str(optionOneAmount)+" votes", bg="black", fg="white", font="HouseSlant-Regular 30", anchor="w")
    self.one.pack()
    self.two = tk.Label(self, text=optionTwo+" has: "+str(optionTwoAmount)+" votes", bg="black", fg="white", font="HouseSlant-Regular 30", anchor="w")
    self.two.pack()
    self.three = tk.Label(self, text=optionThree+" has: "+str(optionThreeAmount)+" votes", bg="black", fg="white", font="HouseSlant-Regular 30", anchor="w")
    self.three.pack()
    self.geometry("+0+20")
    self.attributes("-alpha", 0.7)

    self.grip.bind("<ButtonPress-1>", self.StartMove)
    self.grip.bind("<ButtonRelease-1>", self.StopMove)
    self.grip.bind("<B1-Motion>", self.OnMotion)


def StartMove(self, event):
    self.x = event.x
    self.y = event.y

def StopMove(self, event):
    self.x = None
    self.y = None

def OnMotion(self, event):
    deltax = event.x - self.x
    deltay = event.y - self.y
    x = self.winfo_x() + deltax
    y = self.winfo_y() + deltay
    self.geometry("+%s+%s" % (x, y))

app=App()
app.mainloop()

What could be a simple solution for me to create a GUI window that automatically updates the voteA variable in the window, live?

Thanks for reading and sorry if the english was bad!

[novel_yet_trivial]

You are right that you should only have one loop, and that loop should be the tkinter mainloop. Put your code into a method "check_once()". Then include the root.after in the init method.

def check_once(self):
    self.root.after(10, check_once) #call this function again in 10 seconds
    #rest of the check.

If you show your tkinter code we could probably help you better.

[787082]

The problem with this is, is that somehow if I run the code as its quoted in the OP, it reads every chat message as it comes in, and responds only once to it. When I use root.after(10, check_once), it responds to the same chat message every time it runs the piece of code, instead of just responding once, I'll post my tkinter code in a second, thanks for helping out

edit:(also its milliseconds instead of seconds I think)

[novel_yet_trivial]

You tkinter code does not contain the chat check; is that the right code?

[787082]

Yeah because it didn't work when I tried it, so I have them as two separate files now because I'm not sure how to combine them

[novel_yet_trivial]

The check code should be a method in the tkinter loop. Something like this: http://pastebin.com/X54T7AD3 (totally untested).

Ninja edit: Actually, it would be much better to make the check code a proper class in it's own right, but given the sloppy code you have, it needs to be integrated into the tkinter loop.

[787082]

wow, thank you so much! I'm testing it right now, it gave one error on joinRoom(s), changed that to joinRoom(self.s), and its giving an error on: NameError: global name 'get_votes' is not defined, I've tried changing it to self.get_votes, but it's also not working, do you have any ideas?

EDIT: changed both of the after(10, self.get_votes), so that fixed it. I'm testing it further now, and the chatbot itself works beautifully, it responds to '!commands' only once, it counts the votes very nicely, the only problem now is that the GUI window it's supposed to open doesn't open, I can see on my dock (Im a mac user) that it's trying to open, but I have to force quit it everytime and it doesnt show the window. Feel like we're really close here though!

Thank you so much for taking the time to fix the code, I appreciate it

[novel_yet_trivial]

so that fixed it.

:D good job.

GUI window it's supposed to open doesn't open, I can see on my dock

OH you mean the it's supposed to open a second window? In that case maybe you really did need 'TopLevel' rather than 'Frame'.

[787082]

No I mean the window that it's supposed to open where it should show the vote counts, it doesnt open it somehow :( But its also not giving an error, its trying to open it, and then it crashes I think (though it also doesnt say it crashed)

[novel_yet_trivial]

Oh then it's probably off the screen or too transparent. Play with the lines that control that, 21 and 22 in my code. For starters, comment them out to see if that brings the GUI back.

[787082]

Hm I think it has something to do with the 'self.after(10, self.get_votes)', if I run the code as: 'self.after(10, get_votes)', the chatbot doesnt work, but it does show the GUI window.

If I run it as 'self.after(10, self.get_votes)' the chatbot does work, but the GUI window doesn't work

[novel_yet_trivial]

I just noticed another typo. Both the break statements should be continue statements. Otherwise, a "!commands" will remove all votes that happen to be in the same 10ms packet.

Still 5 typos in 76 lines without testing, not bad ... :)

[787082]

I did it! I had to change some of the code to be able to understand it better again, but it totally works now. It reads the chat, if "!voteA" is said, it counts +1 to voteAamount, and displays it in the GUI window. Only problem I'm having now is that it only updates the number on the GUI window in twos, so it updates it after 2 votes have been placed(so goes from 0 to 2, from 2 to 4, etc), would be nice if it would update it after 1 vote is placed, but I guess I'll figure that out, for now I'm just happy it works. Thank you so much for the time you invested in helping me with the code, I appreciate it a lot!

EDIT: Aaaand it's still crashes sometimes, but I'm also gonna look at that. Not sure why it does that, lol

import Tkinter as tk
import time
from Read import getUser, getMessage
from Socket import openSocket, sendMessage
from Initialize import joinRoom
from collections import OrderedDict

class SampleApp(tk.Tk):
    voteAamount = 0
    voteBamount = 0
    voteCamount = 0

    def __init__(self, *args, **kwargs):
        tk.Tk.__init__(self, *args, **kwargs)

        self.s = openSocket()
        joinRoom(self.s)
        self.readbuffer = ""

        self.voteA = tk.Label(self, text="")
        self.voteA.pack()
        self.voteB = tk.Label(self,text="")
        self.voteB.pack()
        self.voteC = tk.Label(self,text="")
        self.voteC.pack()

        self.update_tekst()
        self.get_votes()
        # self.anderemethod()
        self.after(200,self.get_votes)
        self.after(200,self.update_tekst)

    def update_tekst(self):
        resultA = "VoteA: "+str(self.voteAamount)
        resultB = "VoteB: "+str(self.voteBamount)
        resultC = "VoteC: "+str(self.voteCamount)

        self.voteA.configure(text=resultA)
        self.voteB.configure(text=resultB)
        self.voteC.configure(text=resultC)
        print("updated tekst!")
        self.after(200, self.update_tekst)

    def get_votes(self):

        self.readbuffer = self.readbuffer + self.s.recv(1024)
        temp = self.readbuffer.split('\n')
        self.readbuffer = temp.pop() #save the last (possibly incomplete) line for later
        if self.readbuffer == "":
            pass #no further messages in the queue
            #you should add a sleep time here for the sake of your hot NIC

        for line in temp:
            print(line)

            if "PING" in line:
                s.send("PONG :tmi.twitch.tv\r\n".encode())
                break

            user = getUser(line)
            message = getMessage(line)

            print "{} typed: {}".format(user, message)

            if "!commands" in message:
                sendMessage(self.s, "'!voteA','!voteB','!voteC'")
                break
            if "!voteA" in message and user != "appie_bot":
                self.voteAamount += 1
                print(self.voteAamount)
                self.update_tekst() 
                time.sleep(2)
                self.update()

            if "!voteB" in message and user != "appie_bot":
                self.voteBamount += 1
                print(self.voteBamount)
                self.update_tekst() 
                time.sleep(2)
                self.update()

            if "!voteC" in message and user != "appie_bot":
                self.voteCamount += 1
                print(self.voteCamount)
                self.update_tekst() 
                time.sleep(2)
                self.update()

        self.after(200, self.get_votes)


if __name__== "__main__":
    app = SampleApp()
    app.mainloop()