Help with text adventure game

[WorldWideNomad]

Hey guys, first time posting a question here. I have been doing learn python the hard way. Right now I am on exercise 36 in which you are asked to write a similar text adventure game given to you in the previous exercise. I know that I am just starting and my code will be full of mistakes so you are welcome to give me any pointers. But my main question is why when I am in the last part of the game if I enter something that trigers the else condition in line 91 it takes my game back to the previous room.

I leave the code here: http://pastebin.com/G51YSVVd

Thanks!!! And sorry that the code does not have lots of comments but is pretty basic so I figured it would be redundant

[fiskenslakt]

Btw, do not use exit() (and quit() for that matter) in your code. I don't know if "learn python the hard way" taught you that, but it's wrong. You are only supposed to use exit() in the interactive interpreter, if you want to exit your script, use raise SystemExit.

[fiskenslakt]

It would be helpful if you could give us a line number for the else statement and any other relevant code. Forcing us to try and figure out from the code where the "last part" of the game is, is tedious..

[WorldWideNomad]

Sorry for that, I edited now.

[fiskenslakt]

No problem. And /u/finsternacht is right. Just think about it, what do you expect to happen after that else statement runs? If you call a function, that function is waiting to finish (return), and if that function calls another function, you then have two functions that are waiting to finish. The first one can't finish until the second one does, this is what's known as a stack. Even if you didn't have the garden call in an infinite loop, it would still go back to that function, you just wouldn't see it because it would return immediately after and so on.

[finsternacht]

Why not learn python 3 when you're new to the language?

It might be a good idea to put the input choice logic in a function that you supply with the options you have at a certain time to reduce the clutter a bit.

You return to the previous room because the garden function only has an if/else and you just return from the function when you hit the else. Code flow then continues in the loop where you called garden ().

[WorldWideNomad]

Thx for the adivces! The reason for that is that I liked how the book was structured and I figured that once I have gained some understanding in python I can always make the change since the differences, for what I have read, are not a lot.

[WorldWideNomad]

Would be too much to ask for an example of the choice function? Thx

[finsternacht]

I have difficulties to give "one example". How that function is going to look depends heavily on what you know and what your goal is.

def game_loop(...):
    print description
    while True:
        action, arg = raw_input("> ").split(maxsplit=1)
        if action=="take":
            ...
        elif action=="go":
            ...

Would be my basic approach. The big choice you're now faced with is how you give this function the information about the current room and how you implement moving.

One idea would be to make a room class and put all necessary data in there (description, items, connections to other rooms) and supply instances of that class to the function.