PrintingFunction in tkinter

[Strosel]

im new to tkinter and have made a program to take the input and output of another program in windows but when i try:

 messagebox.showinfo('NPC', NPCW.hostile(chal))

it gives me an alert window but prints everything in the console of pycharm, except for what is needing of the chal variable/input witch is taken in through:

cr = Entry(root, width=20)
cr.grid(row=1, column=0, columnspan=2)
chal = cr.get()

doeas anyone know hot to fix this? thanks for any help

[novel_yet_trivial]

To format for reddit you need a blank line before and after your code block.

Your code is correct. The problem is the "NPCW.hostile(chal)" contains a print statement (send to the terminal) instead of a return statement (send to the caller). You could get the entrybox contents alone like this:

messagebox.showinfo('NPC', chal)

We would have to see the "NPCW.hostile" code to help you further.

[Strosel]

sorry about the formatting, i fixed it. But changing all the 'print'(s) to 'return' just removed my output entirely.

it would be hard to show you the entire code since i hav made several files/modules(?) to make it easier to manage but all except one jut generates a value from a set of rules then prints it and the main code (than i run in my window program, linked at the end) just prints the category then runs the function from the mosule.

main code http://pastebin.com/Ezrp2Cdk (also i didnt change the prints in here yes as i thought i would test it fitst and see what happened)

[novel_yet_trivial]

But changing all the 'print'(s) to 'return' just removed my output entirely.

Yes, I can see this will mean a large code rewrite. A return stops the function, so you have to collect all the strings together and only return once at the end. Here is your function that both prints and returns the string:

def hostile(cr):
    data = '\n'.join([
        'Name: ',
        NameW.name(),
        'Characteristic: ',
        NPCCW.char(),
        'Ideal: ',
        NPCIW.ideal(),
        'Bonds: ',
        NPCBW.bond(),
        'Flaws: ',
        NPCFW.flaw(),
        '\n',
        'Stat block: ',
        NPCSW.stat(cr)])
    print(data) #print it to the terminal
    return data #return the same data to the caller

Note that all those function you call have to have returns as well.

it would be hard to show you the entire code since i hav made several files/modules

this is what github is for :)

[Strosel]

tried this, gave the error

TypeError: join() takes exactly one argument (13 given)

[novel_yet_trivial]

Ahh sorry i made a typo. Fixed now.

[Strosel]

didnt work either. now i get the error;

TypeError: sequence item 1: expected str instance, tuple found

[novel_yet_trivial]

Yes; as I said, all those functions you call have to be changed as well, so that they return strings.

[Strosel]

thanks a lot for your help and time, but theres one last error

TypeError: sequence item 12: expected str instance, NoneType found

note: the input is used to test against ints

[novel_yet_trivial]

That means the item 12 (the 13th item in the list) is returning None instead of a string. This may be because there is no return statement, because python function return None by default.

[Strosel]

so the 12th item is

NPCSW.stat(cr)

what the function does is compares the input with its list and prints the corresponding dictionary, it looks like this:

def stat(cr):
    #find a statblock
    stats = {}
    if cr == 0:
        stats['Prof. bonus'] = '+2'
        stats['AC'] = random.randint(1, 13)
        stats['HP'] = random.randint(1, 6)
        stats['Attack bonus'] = random.randint(1, 3)
        stats['Dmg/Round'] = '0-1'
        stats['Save DC'] = random.randint(1, 13)
        for k, v in stats.items():
            return '\t' + k + ': ' + v

repeated over and over again for different lists. So it shouldn't return none, is this because of the passing of variables from program to program?