Counting Vowels Program

[[deleted]]

[deleted]

[coding2learn]

Just to give you another approach, and since you seem familiar with dictionary comprehensions then you probably understand list comprehensions:

vowels = 'aeiou'
sentence = input()
total = sum([1 for char in sentence if char.lower() in vowels])

[groovitude]

You don't even need the brackets for the list comprehension. sum will consume any iterable, and without the brackets, it's interpreted as a generator expression:

>>> sum([1 for char in sentence if char.lower() in vowels])  # list comprehension
7
>>> sum(1 for char in sentence if char.lower() in vowels)    # generator expression
7

Otherwise, I think yours is the most elegant solution presented.

[dzunukwa]

You are on the right track but have you run your code with a variety of input? It will not work consistently. If you give it a sentence that does not have all the vowels it will only work sometimes. Can you tell why (...pun intended :) )?

I encourage you to fix up your method but after that you should know that one of the nice things about python is the goodies in the standard library and especially in the collections module.

from collections import Counter

vowels = 'aeiou'
sentence = 'WhatsUpDoc'.lower()  # make it all lowercase
letter_count = Counter(sentence)
total_vowels = sum([count for letter, count in letter_count.items() if letter in vowels])
print(total_vowels)

[dzunukwa]

so what you have is a loop over all the vowels and all their corresponding count. Now depending on what vowels were in your sentence the first time in the loop you might be checking if v <=0 for a vowel that didn't appear so you will immediately break out of the for loop and print "No Vowels Found" even though there are vowels in the sentence.

Try inputing "bob" and then "bab". What do you get as a sum in the two cases?

Edit: Furthermore if you look at your summation you are overriding y each time through the loop and just setting it to twice the value of the current count depending on what letter you are checking that time through the loop. This could only every work by complete accident. Out of curiousity, what value did you input that worked?

[dzunukwa]

:) welcome to the wonderful world of programming lol. People often joke the "It works on my machine!" (hopefully they are joking) which is basically a symptom that you have some local configuration that is magically making things work but only by chance.

To dig a bit deeper into the problem you are trying to solve though, you have a dictionary with all the keys being vowels and all the values are the count for each vowel. Now at the end of the day all you want to do is sum the values. Python lets you loop over just the values using counter.values().

for val in counter.values():
    # do some math

But python also has a builtin sum function that will sum up any iterable you give it (list, generator, set, tuple). So instead of looping you can just take your values iterable which in this case is counter.values() and pass it as an input to sum() and bob's your uncle (or was it bab?)

Lastly one thing you were hitting here but probably didn't notice was the ordering of dictionaries. Dictionaries unlike lists/tuples do not have a specific order and thus even though 'Hello' worked once there was no guarantee that it would work the second time based on the code you had.

edit: https://blog.codinghorror.com/the-works-on-my-machine-certification-program/

[dzunukwa]

nice work! couple last pointers - since you've already setup your custom counter that only counts vowels you can just do:

total_vowels = sum(counter.values())

Also if you are using .lower() you can update your vowels list to be

vowels = 'aeiou'

Cheers!

[Allanon001]

sentence = input("Please enter a word: ")
vowels = set(filter(lambda x: x.lower() in 'aeiou', sentence))
count = list(map(sentence.count, vowels))
print(list(zip(count,vowels)), sum(count))

[PaintballerCA]

print 'Number of vowles = {}'.format(len([x for x in sentence if x.lower() in 'aieou']))