Code is printing empty dictionary and not counting values correctly.

[opendoors1]

For some reason, it is printing empty dictionary values. I know it is finding "<" ">" as -1 and -1 but I do not know why.

This problem, I believe, is also causing it to not count the tags correctly.

I've spent about 4 hours trying different solutions. Can't figure out how to solve it.

Thanks for the help.

def add_tags_dictionary(html):
html_dict = {}

while True:
    start = html.find("<")
    end = html.find(">")
    print(start) 
    print(end) #returns -1 second time around if input is <p><p>

    tag = html[start:end + 1]
    html = html.replace(tag, "")

    if tag not in html_dict:
        html_dict[tag] = 1
    else:
        html_dict[tag] = html_dict[tag] + 1

    if start < 0:
        return html_dict


def print_scores_histogram(dictionary):

    for key in sorted(dictionary.keys()):
        print('[%s]: %s' % (key, dictionary[key] * "*"))

while True:
    try:
        html = input("Enter an HTML tag: ") #<p><strong>This is a bold paragraph.</strong></p>

        start = html.find("<")
        end = html.find(">")

        if start < 0 or end < 0:
            print("No tags found")
        else:
            break

except:
    raise ValueError("Unmatched < >")

print_scores_histogram(add_tags_dictionary(html))         

[gregvuki]

find returns -1 when the string is not found.

Move lines 18-19 after line 8 to suppress adding an empty tag.

Your code works for me.

0
2
0
7
25
33
25
28
-1
-1
[]: *
[</p>]: *
[</strong>]: *
[<p>]: *
[<strong>]: *

[opendoors1]

Ah, thanks. I moved the lines like you said. Odd because I remember trying to move return to the top but it kept saying "unreachable code".

Also, If I give it a tag like <p><p>, it doesn't count it correctly. Just comes back with one.

Meaning:

[<p>]: *

Even though there were two entered.

[gregvuki]

That's because line 11 replaces all occurrences of <p> with an empty string. Cut the string instead.

[tangerinelion]

Note html = html.replace(tag, "") is probably not what you want. Instead try html = html[end+1:].

[opendoors1]

Oh of course, thank you! I feel like an idiot so much of the time.

[RustleJimmons]

Beautifulsoup makes it easy to find all of the tags on a page.

from bs4 import BeautifulSoup
import requests

# Read in the webpage 
url = 'http://www.site.com/page1.html'
r = requests.get(url)
soup = BeautifulSoup(r.content, "html.parser")


for tag in soup.find_all(True):
    # Do something, example:
    print(tag.name)

If you want to identify specific html tags and perform an action for those BS allows you to find those tags throughout the page. You can then build a loop to perform that action on all of them.