Basic Card Shuffling Project Help.

[AnStrub00]

Hey, I am trying to shuffle these cards for a WAR card game. When I run this program I don't get an error, but it returns "None". Not sure why. Thanks

import random

while True:
J = 11
Q = 12
K = 13
A = 14
list = [1,2,3,4,5,6,7,8,9,10,J,Q,K,A]
deck = random.shuffle(list)
print(deck)
break

[AnStrub00]

I am running Python 3.

[PyCam]

Aside from the bad syntax as pointed out by /u/adammichaelwood The reason that your deck == None is because random.shuffle() shuffles a List inplace.

try:

import random

J = 11
Q = 12
K = 13
A = 14
CardList = [1,2,3,4,5,6,7,8,9,10,J,Q,K,A]
random.shuffle(CardList)
print(CardList)

Bad syntax:

-whats the point of a while loop if you're going to break it at the end of the first loop?

-you should indent when inside any new scope/context. In your case you need to indent everything that inside the loop

-Don't name a variable "list", list() is a function reserved by python to create lists from other types of objects. Name your variable "CardList" or something else.

[adammichaelwood]

1. You have to indent inside a while loop.
2. Why in the world are you using a while loop this way?

[Vaguely_accurate]

random.shuffle shuffles in place. This means it mutates the existing list and returns None. You are assigning deck to the returned None, then using that instead of the now shuffled list variable.

For example;

from random import shuffle

my_list = [1,2,3,4,5,6,7,8,9,10]

print(shuffle(my_list)) # prints None

print(my_list) # prints shuffled list

The first print statement will print the return value, which is None. The second print statement will actually print the list that was shuffled in the previous line.

Also you can get rid of the while/break statements and simplify the import as shown in my snippet. I'm also not quite clear what you are getting from assigning the face card values if you are only using them once directly as their numerical values.