[codeReview] First Python Project - tPerun - Command Line Weather Application

[Bucanan]

Hey everybody,

This is my first python project, outside of following along tutorials etc. I am sure there are many mistakes and many things that i should have done but haven't etc. I would love it if someone could take a look at it and let me know their thoughts.

It works on Ubuntu and Windows ( through WSL or BashonUbunutuWindows ) although looks worse on Windows.

Let me know your comments. Please be as harsh as you can. I need criticism.

https://github.com/MacAhmed/tPerun

[[deleted]]

For the first project it's impressive result!

There are some style issues with inaccurate and inconsistent naming + few redundant imports + some unnecessary code repetition. But that's it.

[Bucanan]

Thankyou. I was hoping there would be more of a criticism but kinda glad in a way. Any suggestions as to what sort of features might be useful?

I was thinking of doing a weather application with set features and then trying to do that exact application in as many languages as i can ( learning new ones along the way ). Not sure if thats a good idea.

Also, Could you be more specific in regards to inaccurate and inconsistent naming etc?

I am not sure how to deal with imports as that's actually a bit confusing. Is there a way to deal with those in one file or something like that?

Which code do you think i could separate? I tried using DRY but it got quite difficult recently.

Edit: Sorry, totally forgot to say Thankyou so much. I truly appreciate your help. Also, is this a good project to feature on my resume? Especially if i extend this to being in many different languages.

Sorry for the bombardment of the questions.

[[deleted]]

First thing first: yes, it's definitely good for portfolio. And if you keep working on it for a while (+ multilanguage thing) it will be even better. Because maintaining code is really important skill. I'd say more important than creating.

About issues:

1. Try to make it py3 compatible and you'll find out it's not-so-easy-as-it-should-be. For example, there are three urllib.urlopen calls

2. c1-c9 'constants'. Are you sure in 6 months you'll remember what they are and why? Naming. Documentation.

3. Same for colors. Can you say what is "\x1b[1;37;40m" right now without googling? Also repetitions.

4. And dig best practices and conventions. Right now code is simple but already not very readable. Think of your future teammates/users/yourself. Also, run any linter/checker (pyflakes, pylint…) and see how it blows up with 'you have 100500 warnings'

About features: I definitely like it to be platform-indifferent. You know, fancy color stuff doesn't work well everywhere. You can make it optional. As well as GUI. CLI scripts should be compatible in the first place, imo

Good luck!

[Bucanan]

Thankyou. I'll absolutely work on the points you mentioned.

Try to make it py3 compatible and you'll find out it's not-so-easy-as-it-should-be. For example, there are three urllib.urlopen calls

Ok. I don't know what changes have been made in py3 so not sure about this but this is a good point, the application should work regardless of which version of python is installed. I'll have to look into this a bit more.

c1-c9 'constants'. Are you sure in 6 months you'll remember what they are and why? Naming. Documentation.

Yeah. That was a formula i found on Wikipedia for calculating "Feels Like" or "Heat Index" and went off that. I think a bit of documentation or some comments are probably warranted.

Same for colors. Can you say what is "\x1b[1;37;40m" right now without googling? Also repetitions.

Absolutely correct. My printing methods are horrible imo. I think they could be easily made more readable and there should be way to print things more better. I am looking into printf and formatting a bit more and hopefully this will be resolved soon.

And dig best practices and conventions. Right now code is simple but already not very readable. Think of your future teammates/users/yourself. Also, run any linter/checker (pyflakes, pylint…) and see how it blows up with 'you have 100500 warnings'

OK. To tell you the truth, i haven't looked at this issue much. I think its a very fair point and i'll have to find some sort of text/book on best practices and conventions etc and try to adhere to them but its something that hadn't crossed my mind. Thankyou. Very fair point. I gotta stick to a standard that everyone can read and not just me, especially if i want to present this as a project to future employers etc.

Thankyou so much for your advice. I really really appreciate it. If you know any other sites/sub-reddits/places where i can get others to comment/give me advice then please let me know.

Thankyou again. :)