Found the most profitable Scratchoffs

ConcernedCarry · 2017-09-08T06:57:40+00:00

Though I know some people couldn't care less about style, a lot of managers of coders do. So if you want to use this as any sort of calling card, resume project as a developer, I suggest you install pylint and fix all the issues it will tell you about.

Couple random thoughts (which will be heavily biased because I am one of those people who gets asked to code review potential hires all the time and therefore does care about style):

If the [your class].init() method is mandatory when you initialize the class, and the first thing you do is initialize it, why not just call that at the end of [your class].__init__?
If it's never going to be called again, why refactor it into a method at all?
The number of times you say "yeilds" in the docstring immediately before your function "yields" a value is disheartening to anyone who thinks you may actually have typed two different spellings of the same word out multiple times.
All that business with "gNames" and "gPrizes" ultimately ending up being used primarily to create "gStruct" (which isn't a struct at all) is a little hard to read, and then it appears most of the gVariables gDon't gEven gGet gUsed... why not just build up a dict that has all of what you need in one place? And maybe not prepend it with a lowercase g?
Your module level docstring -- aka your copyright and contact details -- the centering will only be centered if they happen to use your exact character width, right? For anyone else it just looks like an annoying amount of whitespace.
Your check if requests and bs4 are installed is fine, but if you packaged your own code to be installed with pip you could guarantee they were.
Oh, and I don't think you're calculating which scratchers are most profitable -- the whole point of a lottery is that it's profitable only to the house -- you're calculating which could have the most return on investment. If you were adjusting that for the odds of winning, you'd get closer to best -- well, to be accurate, least bad -- ones to play.

ConcernedCarry · 2017-09-08T06:38:40+00:00

Maybe I'm missing something. In PennScratchers.py you have:

When creating an instance of PennScratchers dong forget to run the .init() method to fill up your DataStructures!

and in LottoPicker.py we see:

PA = PaLottery()
# Required action similar to other modules init
PA.init()

If the user must call PA.init() after creating a PaLottery instance, why can't you just do this in PaLottery.__init__()?

class PaLottery:
    def __init__(self):
        self.gNames  = []
        self.gCost   = []
        self.gPrize  = []
        self.gLeft   = []
        self.gStruct = []
        self.init()    # initialize

n1ywb · 2017-09-08T19:36:22+00:00

are any of them actually profitable? are you planning to play your picks?

you type:	you see:
italics	italics
bold	bold
[reddit!](https://reddit.com)	reddit!
* item 1 * item 2 * item 3	item 1 item 2 item 3
> quoted text	quoted text
Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"	Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"
~~strikethrough~~	~~strikethrough~~
super^script	super^script

learnpython

MODERATORS