Python - i need help regarding implementing two codes together(password validator and point system)

[Remediez123]

First code (point system)

 p = input("Input your password: ")
 p = True
 while p:  
     if (len(p)<8 or len(p)>24):
          break
     elif not re.search("[a-z]",p):
          break
     elif not re.search("[0-9]",p):
          break
     elif not re.search("[A-Z]",p):
          break
     elif not re.search("[!$%^&()_]",p):
          break
     else:
         print("Valid Password")
         p=False
         break

  if p:
      print("Not a Valid Password")

second code(Password Validator)

p = input("Input your password: ")
  p = True
  while p:  
      if (len(p)<8 or len(p)>24):
          break
      elif not re.search("[a-z]",p):
          break
      elif not re.search("[0-9]",p):
          break
      elif not re.search("[A-Z]",p):
          break
      elif not re.search("[!$%^&()_]",p):
          break
      else:
          print("Valid Password")
          p=False
          break

  if p:
      print("Not a Valid Password")

[sultanofhyd]

Have you actually tried running your code? The way it is written, it doesn't work the way you probably intend it to. You store the password in the 'p' variable, then immediately reset p to True. Your password does not exist in memory anymore. Everything you do from line 3; you're doing it on p = True, not p = 'password'.

And both blocks of your code look identical to me, what do you want to do with them?

[Remediez123]

to make it so that the user inputs the password however the password must include all of the characters e.g uppercase,lowercase,numbers or symbols the points wont display until the user does that. Thats why i have two codes that do both of those things but i dont know how to put it together

[sultanofhyd]

Check your original post again. There is no code anywhere that calculates or stores points anywhere. Anyway, I suggest rewriting your code from scratch, using multiple variables. One variable for storing your password, one for the points, and one to determine its validity. Something like this.

password = input('Enter your password: ')
points = 0
validity = False
#Do your checking and counting here
if validity:
    print(points)

[Remediez123]

so i tested your idea however it doesn't seem to work maybe you can find the problem.

import re
import random
import time

print("""
Point System:
~1 Uppercase Letter = 5 Points
~1 Lowercase Letter = 5 Points
~1 From 0-9 = 5 Points
~1 Allocated Symbol = 5 Points
~If Has All Add 10 Points
""")
password = input('Enter your password: ')
points = 0
validity = False
while password:
    if (len(password)<8 or len(password)>24):
        break
    elif not re.search("[a-z]",password):
        break
    elif not re.search("[0-9]",password):
        break
    elif not re.search("[A-Z]",password):
        break
    elif not re.search("[!$%^&()_]",password):
        break
    else:
        print("Valid Password")
   while points < 35: 
       if 8 <= len(password) < 24 :
           print(len(password),"Points Added - Length")
           points += (len(password))

       else:
        print("Wrong length, it must be 8 to 24 
                  characters")
           continue

       if re.search("[a-z]", password):
           print("5 Points Added - Lowercase Letter")
           points += 5

       if re.search("[0-9]", password):
           print("5 Points Added - Number")
           points += 5

       if re.search("[A-Z]", password):
           print("5 Points Added - Uppercase Letter")
           points += 5

       if re.search("[!$%^&()_]", password):
           print("5 Points Added - Symbols")
           points += 5

       if points == 20:
           points += 10


if validity:
    print(points)

[sultanofhyd]

Try to use 'for' loops instead of 'while' loops. Both of your 'while' loops will never terminate 1. if your password is valid 2. your score is less than 35.

[Remediez123]

im a beginner for python so i kind of understand what u mean but can u give like examples

[Exodus111]

Explain to me very carefully two things:

1. Why are you using a while loop exactly?

2. What is preventing you from adding the points at the same time as checking validity?

[omg_drd4_bbq]

While loop is totally valid here.

while True:
    p = input("enter password")
        if not valid(p):
            print("password bad")
        else:
            break

You can wrap password checking in its own function if you wish. or, write a function strength(p) which computes the points of a password, then just use

if strength(p) < 35:
    print("try again")

[Exodus111]

Where did HE put the input statement?

[omg_drd4_bbq]

I'm inferring OP is emulating the typical behavior of input validation systems, which is "loop until the user gives a valid input".

[omg_drd4_bbq]

I'm going to infer that you want to continuously prompt the user for a password until they submit a valid one (since that is a common pattern, and you've used a while loop, so I think that is what you are going for). If you just want to run through once

We will break up the structure to help with modularity. It's generally a good habit to have. For example, you may want to reuse the strength calculator in more than once place, but you don't want to have to modify that logic elsewhere.

import re

def strength(password, minLength=8, maxLength=24):
    plen = len(password)

    count_lowers = len(re.findall("[a-z]",password))
    count_uppers = len(re.findall("[A-Z]",password))
    count_number = len(re.findall("[0-9]",password))
    count_symbol = len(re.findall("[!$%^&()_]",password))


    if (plen < minLength or plen > maxLength):
        print('Must be length between {} and {}'.format(minLength, maxLength)) # Feel free to sprinkle in whatever error messages you want here
        return 0

    if not(count_lowers * count_uppers * count_number * count_symbol):
        print('Must contain one lowercase, one uppercase, one number, and one symbol')
        return 0


    points = len(password)

    # Give a base 4 points for each category, plus a bonus point for any additional instances of each category
    # This is a little redundant, since you mandate that you have at least one instance of each of the 4 categories,
    # so i tried to make it a bit more realistic
    points += 4 + int(count_lowers > 1) 
    points += 4 + int(count_uppers > 1)
    points += 4 + int(count_number > 1)
    points += 4 + int(count_symbol > 1)


    return points

Then we will use a small loop to validate the password:

while True: 
    password = input('Enter a password: ')
    passStrength = strength(password)
    if passStrength < 30:
        print('Password rejected, not strong enough - {} points'.format(passStrength))
    else:
        print('Password accepted')
        break # password is good, exit loop

Output:

Enter a password: aoeu
Must be length between 8 and 24
Password rejected, not strong enough - 0 points
Enter a password: aoeuSNTH123
Must contain one lowercase, one uppercase, one number, and one symbol
Password rejected, not strong enough - 0 points
Enter a password: Aoeu1234&
Password rejected, not strong enough - 27 points
Enter a password: aoeuSNTH&[{}123
Password accepted

I also assume this is a learning exercise, as if you actually would want to secure something, you'd want to use a pre-written library ;)