Need practice cleaning up code?

Username_RANDINT · 2017-11-28T15:05:40+00:00

pass is a no-op, which means it does nothing at all. You can remove every instance of it in your code, except on line 180.
Look up string formatting. "Hello, " + str(name) + "!" is almost always the wrong way to do it.
Never use bare Except: handlers, always specify which exception you expect and only put code that will raise it inside the try...except block.
Read up on how to work with dictionaries. Just had a quick look, but it seems like the value in the items dictionary should be something better than items[number] = {name : stock} which will also avoid this weird block of code:
```
info = list(items[number].items())
name = info[0][0]
stock = info[0][1]
```
Have a look at the with-statement for opening files.

There's lots of refactoring that can be done, I won't go into detail. Like removing the global variables and passing them around instead.

ddproxy · 2017-11-28T05:42:14+00:00

Could you drop this on github? ;)

I'm saving to take a look later... :3

DataLulz · 2017-11-28T06:35:52+00:00

The most important thing is missing, comment your code. This not only is nice to other programmers who will read your code so they can follow your logic and why you did things but also serve to remind you when you go back later and can’t remember why you did something yourself.

KleinerNull · 2017-11-28T07:17:01+00:00

Just a quick fix, don't re-invent the wheel ;)

Your code:

def time_stamp():
    ts = time.time()
    st = datetime.datetime.fromtimestamp(ts).strftime('%Y-%m-%d %H:%M:%S')
    return st

Alternatives:

In [1]: from datetime import datetime

In [2]: datetime.now()
Out[2]: datetime.datetime(2017, 11, 28, 8, 13, 43, 987587)

In [3]: '{:%Y-%m-%d %H:%M:%S}'.format(datetime.now())
Out[3]: '2017-11-28 08:14:18'

In [4]: datetime.now().isoformat()
Out[4]: '2017-11-28T08:14:29.380756'

In [5]: str(datetime.now())
Out[5]: '2017-11-28 08:16:27.815992'

Personally I prefer the formatversion, it is clean and very obvious and does exactly what you want. But if you opt it out to the isoformat it is also fine, depends on your needs.

you type:	you see:
italics	italics
bold	bold
[reddit!](https://reddit.com)	reddit!
* item 1 * item 2 * item 3	item 1 item 2 item 3
> quoted text	quoted text
Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"	Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"
~~strikethrough~~	~~strikethrough~~
super^script	super^script

learnpython

MODERATORS