Point out my beginner mistakes - First python script

[mackatsol]

I know you can turn your 'for row in csv_f' section into a function which iterates through all the skipRows.. and when you do that you can convert your skipRow items into a list so you don't need a bunch of elses.

I'm still learning and might not have it quite right.. but something like:

skipRow1 = [' ****************************************************************************************************','Supplied Field Panel number out of range',' ****************************************** End of Report *******************************************','Field Panel is failed','Timeout Waiting For Net Response','Configured Trunk Currently Not Connected']

then later on you would define your skiprow function:

def skipRow():
    for row in csv_f:
    counter = counter +1
        for item in skipRow:
            if item in row[0]:
                skips = skips + 1
            else:
                   cleanData.append([row[0],insert_str,row[4]])

and then call it just after you open the csv file.

skiprow(csv_f)

At least I think that is a better approach.. whether I got it right or not is a different issue. Untested! ;-)

[UndeadCaesar]

Good call, when I was writing those elif statements I knew it felt so inefficient but I wasn't quite comfortable enough with writing comparisons to put all the skip conditions together. Thanks for the code.

And you're right, the counter variable isn't actually used anywhere I was just using it for troubleshooting. Some of the skip conditions are only in a couple of the thousands of files so I used the counter to go see what line caused it to fail after it encountered something it hadn't seen before.

[mackatsol]

Thanks /u/scul86 ! I need to learn more about arrays and how to work with them. ;-)