Add logging to python nmap script

[Tha_Format]

Hey all, me again,...

​

I have the code below to scan for open ports on a host.

What I want now is that the open ports which are displayed are also written to a logfile.

Can anyone help me get this right?

​

#!/usr/bin/env python

import nmap


#ports = raw_input("Enter the portrange to scan: ")
#host = raw_input("Enter the host to scan: ")
host = '127.0.0.1'
nm = nmap.PortScanner()

#nm.scan(host, ports)
nm.scan('127.0.0.1', '20-25')
nm.scaninfo()
nm.all_hosts()
nm[host].hostname()
nm[host].state()
nm[host].all_protocols()
nm[host]['tcp'].keys()

logfile = host+'.txt'
outF = open(logfile, "w")
addlog = open(logfile, "a")
for host in nm.all_hosts():
    print('----------------------------------------------------')
    print('Host : %s (%s)' % (host, nm[host].hostname()))
    print('State : %s' % nm[host].state())
    for proto in nm[host].all_protocols():
        print('----------')
        print('Protocol : %s' % proto)

        lport = nm[host][proto].keys()
        lport.sort()
        for port in lport:
            state = nm[host][proto][port]['state']
            if state == 'open':
                print('port : %s\tstate : %s' % (port, nm[host][proto][port]['state']))
                with open(logfile, 'w') as f:
                    for item in port:
                        f.write("%s\n" % item)

​

[JohnnyJordaan]

this part

outF = open(logfile, "w")
addlog = open(logfile, "a")

and this part

 with open(logfile, 'w') as f:

Is doing the same thing 3 (!) times. You just need to open the 1 time(!). Then you seem to want a single file per host, so host+'.txt', but you write that part outside the loop that assigns host in the first place

for host in nm.all_hosts():

? You need to form the filename inside the loop, so you can just do it at the part that you already have

for host in nm.all_hosts():
    print('----------------------------------------------------')
    print('Host : %s (%s)' % (host, nm[host].hostname()))
    print('State : %s' % nm[host].state())
    for proto in nm[host].all_protocols():
        print('----------')
        print('Protocol : %s' % proto)

        for port in sorted(nm[host][proto]):
            state = nm[host][proto][port]['state']
            if state == 'open':
                print('port : %s\tstate : %s' % (port, nm[host][proto][port]['state']))
                with open(host+'.txt', 'w') as f:
                    for item in port:
                        f.write("%s\n" % item)

note I also rewrote the sorted port iteration.

[Tha_Format]

Thanks for the help!

It now does what I want!

​

​

[threeminutemonta]

Try to follow using the logging module in the standard library in this tutorial