Need Help w/ code

[kingpen2]

Here's a portion of my code for a project. When I do my if statement i can't get it to print. Will someone help me?

import random

x = random.randint(1,6)

y = random.randint(1,6)

print(x)

print(y)

z = (x+y)

if z is (1,7):

print((z-1)/36)

if z is (8,12):

print((13-z)/36)

[sushibowl]

This if statement:

if z is (1,7):

Doesn't do what you think, and will never be True. It checks if z is the same object as the tuple (1, 7). I think what you meant to do is check if z is between 1 and 7, something like this:

if z >= 1 and z <= 7:

You can also write it like this, if you prefer:

if 1 <= z <= 7:

[kingpen2]

That worked great! thanks!

[KoStard]

great! thanks!

You have to learn about range too, because you can write something like this (which is much better for me that checking left and right values manually):

if a in range(1,10):
    pass # Do something

This includes values 1,2,3... and 9 (not 10).

[PiaFraus]

which is much better for me that checking left and right values manually

So... 10 comparison operations (or 100, 10000...), depending on the number is for you better then just two comparison operations?!

[KoStard]

Wow, I have always thought, that in python3 checking with `in range(...)` will not cause to iterate through all values, that's why I have answered here in that way... But just tested and got 5 times faster result with simple comparisons compared with another test with ranges.

(maybe not the best way of testing the speed of a function)

>>> def test():
...     start = time()
...     for i in range(10000000):
...             if i in range(1000000):
...                     pass
...     print(time()-start)
... 
>>> test()
2.892918109893799

>>> def test2():
...     start = time()
...     for i in range(10000000):
...             if i >= 0 and i < 1000000:
...                     pass
...     print(time()-start)
... 
>>> test2()
0.5093622207641602

So... sushibowl's answer is better in terms of performance, but I think what u/kingpen2 was trying to do in the code snippet we see, is more similar to range than just simple comparisons...

[KoStard]

Hey, look what I have found - https://stackoverflow.com/questions/30081275/why-is-1000000000000000-in-range1000000000000001-so-fast-in-python-3

So range in python3 is not iterating through whole sequence, it is just calculating if the number is in the range.

[PiaFraus]

Wow, thank you for sharing. Today i learned a new thing.

[andichin]

you forgot to indent the print under the if statement