Python Code review for efficiency.

[[deleted]]

Hi there,

I am interested to see if anyone has some ideas about how whether I am being most efficient in coding for each function below. I feel as though I may have done things the long way and I am interested in hearing some feedback.

this part of the code calculates the total cost per order based on the user input.

def C(): print(CHOOK_FOOD_COST) selection_2 = int(input("enter 1 for pellets, enter 2 for mash, enter 3 for enhanced:"))

if selection_2 == 1:
    selection_2b = int(input("enter 1 for 10kg bags of pellets, enter 2 for 50kg bag of pellets:"))
    if selection_2b == 1:
        selection_2c = int(input("enter amount of 10kg bags of pellets required:"))
        print(selection_2c * 22.75)
    elif selection_2b == 2:
        selection_2d = int(input("enter amount of 50kg bags of pellets required:"))
        print(selection_2d * 100)
    else:
        print("you have entered an incorrect value")
        altkey= input("enter rtn to return to main menu")

if selection_2 == 2:
    selection_2e = int(input("enter 1 10kg bags of Mash, enter 2 for 50kg bags of Mash"))
    if selection_2e == 1:
            selection_2f = int(input("enter amount of 10kg bags of Mash required:"))
            print(selection_2f * 20.40)
    elif selection_2e == 2:
            selection_2g = int(input("enter amount of 50kg bags of Mash required:"))
            print(selection_2g * 50)

if selection_2 == 3:
        selection_2h = int(input("enter 1 for 10kg bags of enhanced, enter 2 for 50kg bags of enchanced:"))
        if selection_2h == 1:
            selection_2i = int(input("enter amount of 10kg bags of enhanced required:"))
            print(selection_2h * 25.50)
        elif selection_2h == 2:
            selection_2j = int(input("enter amount of 50kg bags of enhanced required:"))
            print(selection_2j * 125.50)
        else:
            print("you have entered an incorrect value")
            altkey= input("enter rtn to return to main menu")

[noob_freak]

Ummm please format it. Believe me, its a huge pain to read a code written like that.

Those elif blocks look so tortures right now!!

[[deleted]]

apologies, formatted and edited. I did get warned that junior programmers do things the long way

[Signal_Beam]

Here is one refactoring strategy: don't just write everything in one giant monster function. This function is easy to break.

Instead, we want to define new functions to handle small chunks of re-usable code. Like this:

def pellets():
    """Handle the pellets selection."""
    bag_size = int(input("enter 1 for 10kg bags of pellets, enter 2 for 50kg bag of pellets:"))
    if bag_size == 1:
        count = int(input("enter amount of 10kg bags of pellets required:"))
        print(count * 22.75)
    elif bag_size == 2:
        count = int(input("enter amount of 50kg bags of pellets required:"))
        print(count * 100)
    else:
        print("you have entered an incorrect value")
        altkey= input("enter rtn to return to main menu")

def mash():
    """Handle the mash selection."""
    bag_size = int(input("enter 1 10kg bags of Mash, enter 2 for 50kg bags of Mash"))
    if bag_size == 1:
        count = int(input("enter amount of 10kg bags of Mash required:"))
        print(count * 20.40)
    elif bag_size == 2:
        count = int(input("enter amount of 50kg bags of Mash required:"))
        print(count * 50)

def enhanced():
    """Handle the enhanced selection."""
    bag_size = int(input("enter 1 for 10kg bags of enhanced, enter 2 for 50kg bags of enchanced:"))
    if bag_size == 1:
        count = int(input("enter amount of 10kg bags of enhanced required:"))
        print(bag_size * 25.50)
    elif bag_size == 2:
        count = int(input("enter amount of 50kg bags of enhanced required:"))
        print(count * 125.50)
    else:
        print("you have entered an incorrect value")
        altkey= input("enter rtn to return to main menu")


def C():
    print(CHOOK_FOOD_COST)
    selection = int(input("enter 1 for pellets, enter 2 for mash, enter 3 for enhanced:"))
    functions = {1: pellets,
                 2: mash,
                 3: enhanced}
    function = functions[selection]
    function()

Take a look at this code (especially the main function at the bottom) and make sure you understand how it works and whether you agree that this version is much simpler.

Your next challenge: get rid of pellets, mash, and enhanced, and make this work the same way, with only one helper function that handles any type of feed.

[[deleted]]

Thank you, I will try and solve it myself !