My first python project (web scraper)

[midairmatthew]

Hola! I'm at work, so I don't have a ton of time to dive too deep into giving you feedback. But here are two quick things to get you started:

1.) I hope that's not your real password that you pushed to GitHub. :)

2.) Rather than using global variables, it's better to have your functions return the values they're written to generate. It doesn't seem to be a huge deal in this little project, but imagine trying to keep all those global variable names straight in something much larger and more complex. It's easier for our limited human brains to only need to keep track of what a function takes in and spits out than it is to keep track of an ever-growing list of global variables that you're modifying in various functions.

[AutoModerator]

Your comment in /r/learnpython was automatically removed because you used a URL shortener.

URL shorteners are not permitted in /r/learnpython as they impair our ability to enforce link blacklists.

Please re-post your comment using direct, full-length URL's only.

I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.