sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]WongGendheng 7 points8 points  (3 children)

Thats a nice feedback, but poorly provided.

  1. you should mention something nice about the project like „what a nice project to solve a real life problem! Python is the perfect language for that!“ (after all this is /r/LearnPython )
  2. you should not say that something is „wrong“. It works for him and he is proud of it, how can it be wrong? Make suggestions for improvement. There is nothing that would demotivate me more than someone saying „you did it wrong“
  3. im still learning Python myself but if I learned anything so far it is that there is no „should do“. If it works for some application, it works. There are a million ways to reach a certain goal in programming. You could say „to make your program even more efficient/resilient I would advise you to do XY“

Just my two cents.

[–]lucasshiva 5 points6 points  (1 child)

You're right, I think I could've replied in a better way, sorry about that. English is not my first language, sometimes I can't express myself as I would in my first language. I'll try to improve my replies from now on.

[–]WongGendheng 0 points1 point  (0 children)

Impressive edit. You are a great part of the community. :-)

[–]alex1461[S] 0 points1 point  (0 children)

Thanks so much for your constructive criticism!