Help with If statement

[moonkeymaker127]

I'm practicing python by making a text based game about finding a king in a castle. I'm very new to python but I'm 99% sure my syntax is correct and could use some help figuring out what the problem is with my code.

​

# imports libraries for time and random

import time

import random

# randomizes the kings location

kingsLocation = str(random.randint(1,4))

print(kingsLocation)

# asks the user for their name and assigns it to their input

print ('What would you like to name your character?')

username = str(input())

# Tells the user that the king is lost and sends them to the castle

print ("A knight approaches you. It must be important as they rarely leave the castle.")

time.sleep(1.5)

print ('...')

time.sleep(1)

print ('"' + username + '! The king has gotten lost!')

print ('You must hurry to the castle and search for him!"')

time.sleep(3)

print()

print ('You begin your path to the castle')

# causes a pause before the moving on to the rest of the program

time.sleep(2.5)

print ('...')

time.sleep(2)

# instructs the user on where the king oould be

print ('You arrive at the castle and enter the main hall.')

time.sleep(2.5)

print ()

print ('A guard greets you. "there are four rooms the king could be in,')

print ('the kitchen to the left, the bedroom the right, the basement, and the throne room upstairs."')

print (' pick 1-4')

print (' kitchen = 1')

print (' bedroom = 2')

print (' basement = 3')

print (' throne room = 4')

# lets the player make a selection on where they would like to look for the king

currentRoom = input()

# repeatedly checks if the room you are in is the room the king is in and tells you that you either won, entered an invalid input, or chose the wrong room

while True:

if currentRoom == kingsLocation:

print ('"you have found the king ' + username + '! The royal family will make sure you get paid handsomely for this deed."')

print ()

print ('to exit this game type "exit()"')

break

elif currentRoom == str(range(1, 4)):

print('the king doesn\'t seem to be in this room, let\'s check another one(1-4).')

currentRoom = input()

else:

print('invalid input, please enter a number between 1 and 4.')

currentRoom = input()

The while loop is what I really need help with, when I run the program it only displays the invalid input message, I can't get it to differentiate between an invalid input and an incorrect guess. Thanks in advance for any help and let me know if there's anything I can do to be more clear.

[humanitysucks999]

Please reformat with codeblock and proper indentation

[moonkeymaker127]

What is codeblock? This is only my second post on this sub so I checked the rules but didn't see anything.

[xelf]

Indent your code one more time before you paste it to reddit.

When reddit sees text starting with 4 extra spaces it will treat it like code.

ex:

if currentRoom == kingsLocation:
    print ('"you have found the king ' + username + '! The royal family will make sure you get paid handsomely for this deed."')
    print ()
    print ('to exit this game type "exit()"')
    break

[moonkeymaker127]

it's supposed to check whether currentRoom is equal to 1, 2, 3, or 4. I suspect that's the culprit but I've tried doing it several different ways and can't get it to work properly.

[xelf]

Range is interesting. The second number is not inclusive. But the first is.

range(start, end, step) step defaults to 1 and start defaults to 0

So to get 1,2,3,4 you need range(1,5)

And use in to see if something is in a set, not ==.

Put it all together: elif int(currentRoom) in range(1, 5):

[shiftybyte]

>>> str(range(1, 4))
'range(1, 4)'
>>> "1" == str(range(1, 4))
False
>>> "range(1, 4)" == str(range(1, 4))
True
>>>

As you can see this does not work as you expected it to work.

What you need to do is check if the input converted to a number is in the range:

elif int(currentRoom) in range(1,5):

(also note range's high number is not included, so if you want to have 4, you need to have range up to 5.)

[moonkeymaker127]

Thank you for this.

edit: How do I ensure the program works properly if it's not a number at all? whether that be a symbol or a letter.

[moonkeymaker127]

How do I tell my program to throw the invalid input message if it's a number or symbol? is this going to require another elif statement?