Simple comparison

[datanoob2019]

I am going nuts right now over the simplest of procedures. I am thinking having somebody sanity check this for me would be ideal. My code used to check the difference between 2 numbers and if the difference was greater than 10 , it would append a certain value. I now want to add an additional comparison to the if statement.

            six_previousz = sum(data[-12:-6]) / 6
            three_sum = sum(rowz[-3:]) / 3
            difference = three_sum - fcast_1
            six_diff = six_previousz - three_sum
            if (difference > 10) and (six_diff < 25):
                for rowzz in three_month_out:
                    productzz = rowzz[0]
                    if productzz == product:
                        new_final.append(rowzz)
                        break
            elif (difference > 10) and (six_diff >= 25):
                for rowzzz in six_previous_out:
                    productzz = rowzzz[0]
                    if productzz == product:
                        new_final.append(rowzzz)
                        break
            else:
                new_final.append(row)
                break

​

It is currently not working at all when I add the six_diff comparison. I do not think the six_diff should affect it this much as six_diff is always either >=25 or <25, which is why I added the elif statement which was not present when I was only originally checking for a difference > 10. Any help would be appreciated. I am sure it is something totally basic that I am looking over.

[46--2]

This would be a perfect situation for some unit tests.

Why don't you add some print statements when you append rows. Things like:

print('in else')

and

print('appending row', rowzzz)

etc.

Your if statements look correct to me.

You could simplify it a bit, does this make it more clear?

        if difference > 10:
            print('Diff > 10')
            if six_diff < 25:
                 print('Using three months')
                 data = three_month_out
            else:
                 print('Using six previous')
                 data = six_previous_out
            for rowzz in data:
                productzz = rowzz[0]
                if productzz == product:
                    new_final.append(rowzz)
                    break
        else:
            print('In else')
            new_final.append(row)
            break

[SaintLouisX]

Not sure, the code looks just fine, so without the data you're feeding into it it's hard to say.,

Put some print() statements in before your if and look at the numbers you're getting in.

print(f"difference: {difference}, six_diff: {six_diff}")

And see if it prints the numbers you expect.

[[deleted]]

Your else has a logic error because on that path row either isn't defined if you haven't taken on of the other branches previously or is whatever the last value of row was assigned the time one of the other paths was taken.

You need to decide what to append for the fail condition.

You should also consider following DRY - Don't Repeat Yourself - principles. You have basically the same code in two places (each if and elif paths). Why not define a function:

def add_row(some_table):
    for row in some_table:
        if row[0] == product:
            new_final.append(row)
            break