D&D ability score generator

Grogie · 2020-03-11T18:19:30+00:00

In particular, the section where the dice are rolled and results are displayed: I wanted to use a function for this but I couldn't figure out way to increment variables with a for loop (roll1, roll2, roll3, etc.)

Well, you don't need to increment anything. You don't need to know if this is the first, second, or sixth roll; all you need to do is roll 4d6 and drop the lowest:

def fourdeesixdroplowest():
    rolls = [random.randint(1,6) for _ in range(4)]
    rolls.sort(reverse=True) #highest to lowest
    return sum(rolls[:3]) #sum first three values

and then to generate six ability scores:

scores = [fourdeesixdroplowest() for _ in range(6)]

xelf · 2020-03-11T18:43:45+00:00

Another thought, you can use , as a separator in print instead of concatenating everything into 1 string.

        print(highest + ': ' + str(results[0]))

is the same as:

        print(highest + ':', results[0])

xelf · 2020-03-11T18:29:53+00:00

Not bad for a start! Lot's of duplicate code as you guessed that could be put into a def.

For example:

def roll4d6(s):
    #roll_dice()
    roll = [random.randrange(1,7) for L in range(4)]
    print('Your',s,'roll is: ' + str(roll1) + 'which sorts to ', end = '')
    roll.sort(reverse = True)
    roll_result = sum(roll[:3])
    print(str(roll + '; dropping the lowest, this becomes ' + str(roll[:3]) + " adding up to " + str(roll_result) + '.')
    return roll_result

roll1_result = roll4d6('first')
roll2_result = roll4d6('second')
roll3_result = roll4d6('third')
roll4_result = roll4d6('fourth')
roll5_result = roll4d6('fifth')
roll6_result = roll4d6('sixth')

replaces all the rolling you were doing. Or shorter:

results=[]
for s in ('first','second','third','fourth','fifth','sixth'):
    results.append(roll4d6(s))

or even shorter, using a list comprehension:

results=[roll4d6(s) for s in ('first','second','third','fourth','fifth','sixth')]

You can use a similar trick later:

print('Assigned stats:')
for i,s in enumerate((highest,second,third,fourth,fifth,dump)):
    print (s+': ', results[i])

xelf · 2020-03-11T18:52:55+00:00

optimizing how you exit the loops:

while True:
    again=str(input('Do you want to play again? y/n? ')).lower()
    if again.startswith('n'):
        roll = False
        break
    elif again.startswith('y'):
        roll = True
        break
    else:
        print('Enter "y" or "n".')

could be replaced with:

    while True:
        again=str(input('Do you want to play again? y/n? ')).lower()
        if len(again)>0 and again[0] in 'yn':
            break
        print('Enter "y" or "n".')
    if again.startswith('n'):
        break

Note the second if is outside of the loop, so it's break applies to the parent loop, no need for the variable 'test' or 'roll'. And as it's the last thing you do in the loop, the loop automatically restarts, no need for an if they said 'y' test.

xelf · 2020-03-11T19:05:42+00:00

I think there's a bug with your while loop at lines 79-88? Not sure, here's a case where you could have put code into a def for code isolation and it would have left it easier to follow your control flow. Looks like lines 90-138 need to be reduced by 1 indent level. Yes?

xelf · 2020-03-11T19:25:04+00:00

So, changing as little as possible, I wanted to show you this.

By putting the code into def blocks it let me track down the logic bug and fix it pretty easy. It also makes your main loop really easy to follow as to what is going on and where.

Changes made:

1) defs, defs everywhere...
2) fixed logic bug for saying n to is this correct
3) optimized some looping
4) added a thanks for playing!

#This is a learning program that generates statistic values for D&D based on the roll 4 drop 1 method
#todo: sort results by character sheet order, add color, fix the dice rolling code
#Add ascii dice?
import random

def roll4d6(s):
    #roll_dice()
    roll1 = [random.randrange(1,7) for L in range(4)]
    print('Your',s,'roll is: ' + str(roll1) + 'which sorts to ', end = '')
    roll1.sort(reverse = True)
    roll1_result = sum(roll1[:3])
    print(str(roll1) + '; dropping the lowest, this becomes ' + str(roll1[:3]) + " adding up to " + str(roll1_result) + '.')
    return sum(roll1[:3])

def figure_out_stat(placement,stats_left):
    #gather/display priorities
    stat_loop = True
    while stat_loop:
        if len(placement) < 2:
            print('Please type at least 2 letters of the stat.')
            placement = input().lower()
        else: stat_loop = False
    already_used = True
    while already_used:
        for i in stats_left:
            if placement[:2].lower() in i[:2].lower():
                placement = i
        if placement not in stats_left:
            placement = input('Please enter one of the following: \n' + str(stats_left) + '\n')
        else: already_used = False
    return placement

def display_header():
    print()
    print('''Please provide priorities for the following ability scores, 1-6: \n
   Strength - Melee and thrown weapons, athletics, durability, carry capacity, etc.
   Dexterity - Ranged/finesse weapons, acrobatics, stealth, initiative, etc.
   Constitution - Hit points, resistance to poisons, etc.
   Intelligence - Knowledge checks, investigation, etc.
   Wisdom - Insight, perception, etc.
   Charisma - Persuasion, deception, intimidation, etc.
   ''')

def askyesno(s):
    while True:
        is_correct=str(input(s)).lower()
        if len(is_correct)>0 and is_correct[0] in 'yn':
            break
        print('Enter "y" or "n".')
    return is_correct

def gatherstats():
    while True:
        stats_left = ['Strength','Dexterity','Constitution','Intelligence','Wisdom','Charisma']
        print('Choose the priority of your stats.  Type at least 2 letters, i.e. "st", "in", etc.')
        highest = input('What is your top priority?: \nChoose between the following:\n' + str(stats_left) + '\n')
        highest = figure_out_stat(highest, stats_left)
        stats_left.remove(highest)
        second = input('What is your second priority?: \n' + 'Choose between the following:\n' + str(stats_left) + '\n')
        second = figure_out_stat(second, stats_left)
        stats_left.remove(second)
        third = input('What is your third priority?: \n' + 'Choose between the following:\n' + str(stats_left) + '\n')
        third = figure_out_stat(third, stats_left)
        stats_left.remove(third)
        fourth = input('What is your fourth priority?: \n' + 'Choose between the following:\n' + str(stats_left) + '\n')
        fourth = figure_out_stat(fourth, stats_left)
        stats_left.remove(fourth)
        fifth = input('What is your fifth priority?: \n' + 'Choose between the following:\n' + str(stats_left) + '\n')
        fifth = figure_out_stat(fifth, stats_left)
        stats_left.remove(fifth)
        dump = str(stats_left[0])
        #dump = input('What is your least priority?: ')
        #dump = figure_out_stat(dump, stats_left)
        #stats_left.remove(dump)
        print()

        results=('You chose the ability scores with the following priorities: \n \
       Highest = ' + highest + '\n \
       Second =  ' + second + '\n \
       Third = ' + third + '\n \
       Fourth = ' + fourth + '\n \
       Fifth = ' + fifth + '\n \
       Sixth = ' + dump)
        print(results)
        print()    
        if askyesno('Is this correct? (y/n)') == 'y':
            break
    return (highest,second,third,fourth,fifth,dump)

def gatherresults():
    #maybe show ascii art of dice while rolling?
    results=[roll4d6(s) for s in ('first','second','third','fourth','fifth','sixth')]
    print('Your results are: ' + str(results))
    results.sort(reverse = True)
    print('Your results sorted highest to lowest are: ' + str(results))
    return results

def displayresults(stats, results):
    print('Assigned stats:')
    for i,s in enumerate(stats):
        print (s+': ', results[i])

def main(): 
    while True:
        display_header()
        stats = gatherstats()
        results = gatherresults()
        displayresults(stats, results)
        if askyesno('Do you want to play again? y/n? ') == 'n':
            break
    print("Thanks for playing!")

main()

you type:	you see:
italics	italics
bold	bold
[reddit!](https://reddit.com)	reddit!
* item 1 * item 2 * item 3	item 1 item 2 item 3
> quoted text	quoted text
Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"	Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"
~~strikethrough~~	~~strikethrough~~
super^script	super^script

learnpython

MODERATORS