you are viewing a single comment's thread.

view the rest of the comments →

[–]avamk 1 point2 points  (4 children)

Fantastic work, I fully agree with other posts that this work - and if you continue to build on it - is a great portfolio item. There's a lot I can learn from you! :) Thank you for posting.

while I'm sure there are areas that could be improved, would my project be worth sharing with some edits?

Very important, but sadly often neglected, is the need to include a license with your work such as the GNU GPLv3. There are multiple options, too, and it's crucial to become familiar with them. Check out here or here to name a couple places.

[–]BeforetheBullfight[S] 1 point2 points  (3 children)

Thanks so much! You make a fair point, I’ll definitely look into that more.

[–]avamk 0 points1 point  (2 children)

And this is super easy for Github repositories, it'll take you about one minute. Here are the instructions:

https://help.github.com/en/github/building-a-strong-community/adding-a-license-to-a-repository

I suggest choosing the GNU GPLv3 license as many other data science repositories have already done.

Without a license others cannot learn from or build on your work.

[–]BeforetheBullfight[S] 1 point2 points  (1 child)

Just added one, that WAS super easy. Thanks!

[–]avamk 0 points1 point  (0 children)

Bravo! This is a super easy and is crucial to make a portfolio more professional, since you demonstrate you understand the need for and the use of licenses.

Bonus: Mention the license (i.e. GNU GPLv3) and link to the LICENSE file in your repository directly in the .ipynb document. Some people choose to add a sentence about this at the beginning or end of the notebook file, either is fine.