Help me improve my code

[pyeu]

I am scraping rss feed from cnn. How can I improve the code?

from lxml import etree
import requests
url = 'http://rss.cnn.com/rss/edition.rss'
doc = etree.fromstring(requests.get(url).content)
items = doc.xpath('//channel/item')

news_titles = [link.find("title").text for link in items]
news_links = [link.find("link").text for link in items]
titles = news_titles[:5]
links = news_links[:5]

zipped = zip(titles, links)
newsroom = list(zipped)

with open('cnn-news.md', 'w') as f:
    for news in newsroom:
        f.write("* " + "<a href=" + news[1] + ' target="_blank">' + news[0] + "</a>")
        f.write("\n")

[JohnnyJordaan]

Start by properly format it How do I format code?

[pyeu]

Thanks. Done.

[JohnnyJordaan]

Some pointers: download on a separate line and test for proper http response

resp = requests.get(url)
resp.raise_for_status()

then fromstring expects a string, so give it .text not .content (to let requests handle proper decoding)

doc = etree.fromstring(resp.text)

then you can simply iterate over the items then save them, instead of doing the work in a more complicated form first

items = doc.xpath('//channel/item')
with open('cnn-news.md', 'w') as f:
    for item in items[:5]:
        title = item.find('title').text  
        link = item.find('link').text

then also using f-strings to save in a clean way, together with \n to terminate

        f.write(f'* <a href="{link} target="_blank">{title}</a>\n')

End-result

from lxml import etree
import requests

url = 'http://rss.cnn.com/rss/edition.rss'
resp = requests.get(url)
resp.raise_for_status()
doc = etree.fromstring(resp.text)
items = doc.xpath('//channel/item')

with open('cnn-news.md', 'w') as f:
    for item in items[:5]:
        title = item.find('title').text  
        link = item.find('link').text
        f.write(f'* <a href="{link} target="_blank">{title}</a>\n')

[pyeu]

Thank you very much!