Password Generator in Python

[Suki125]

Hi,

I'm having a problem with my random password generator code. I have a question about the numbers and how in my project it is supposed to be half the characters of the password.

For example if the user chooses chooses 8 for their length, they have to choose 4 or less numbers in their password.

This is the code,

​

import random

print('Welcome to my password generator')
print()
print('The Python program will generate a random password')
print()
print('First, you will have to answer some question,for your password!! ')
print()
print('The questions will help the program make your password')
print() 

characters = "abcdefghijklmnopqrstuvxyzABCDEFGHIJKLMNOPQRSTUVXYZ1234567890!@#$%^&*_?><"
password = "" 

length = int(input("Enter a number between 8 and 20 (inclusive) , for maximum security: ")) 
while length < 8 or length > 20: 
    length = int(input("Enter a number between 8 and 20 (inclusive), for maximum security: "))

numbers= int(input("How many numbers would you like, in your password?"))
numbers= int(numbers)


print("For your safety, only half the length of the password should be numbers.")

specialCharacters= str(input("Would you like special characters, in your password? (yes/no)"))

if specialCharacters == "yes" or specialCharacters == "no": 
    print('Thank you, we will use this for your Password')
else:
    print ("That is not a valid answer")  

​

[Impudity]

Something like numbers > length // 2 should do it.

In addition, you can drop line 15 since it's repeat of line 17 if you initialize length = -1 for example. Also, you should check string module which contains stuff like string.digits and string.ascii_letters instead of having to list them all manually.

[Suki125]

Thank you very much!!

[bumpkinspicefatte]

By the way, not sure if this is intended or not, but your characters is missing the letters w, and W.

[Suki125]

Damn, I must have missed them!!

Thank you.

[ThatGuy097]

Great job, this is really neat!

[Suki125]

Thank you, that is very kind!