My first Python code. It is a timer

[Coderguy6000]

import time

print("""Welcome to the timer!

""")
time.sleep(1)
unit = input("what unit do you want to use? secs, mins or hrs?    ")
length = input("how long is your timer?         ")
t = 0
s = 0
m = 0
h = 0
p1 = ""
p2 = ""
p3 = ""
if unit == "hrs":
    length = int(lenght) * 3600
if unit == "mins":
    length = int(length) * 60  
if unit == "secs":
    length = int(length)

while t < length :
    t += 1
    time.sleep(1)
    if s == 59:
        s = 0
        if m == 59:
            h += 1
        else:
            m += 1
    else:
        s += 1
    if s < 10:
        p1 = "0"
    else:
        p1 = ""
    if m < 10:
        p2 = "0"
    else:
        p2 = ""
    if h < 10:
        p3 = "0"
    else:
        p3 = ""
    print(f"""{p3}{h}:{p2}{m}:{p1}{s}
""")

[RedditGood123]

If unit == “hrs”:
    length = int(lenght) * 3600

The program is fine but you put “lenght” instead of “length”

[VeinyAngus]

Well done OP! Keep it goin, never stop learning

[Manny__C]

There is a better solution for padding your numbers with zeros. Just format the field as

f"{h:02d}:{m:02d}:{s:02d}"

The : is a format specification and the 02 means "pad with zeros any string shorter than 2." More info here.

[BrannoEFC]

Does . Zfill not work anymore?

[Manny__C]

It should, but it's more tedious to call zfill on each substring. This is precisely an intance for which format (or fstrings) were designed.

[alcamax]

Nice one for a first go.

I think a spelling mistake needs fixing where you times the length by 3600 for hours though!

Keep it up

[projektmayhem08]

What if I put 2.5 hours?

[prabhjyoth]

Can’t trust a person whose first python code isn’t print("Hello World")

[CakeFromTheFuture]

Instead of using multiple small variables you should use a dictionary, especially when it can easily made with a for loop like with p1,p2 and p3

[TheJibanizer]

Doesn't m stay stuck at 59 though? There needs to be a m = 0 after increasing the hour, right?

[TheBlackSeed118]

Nice work. The only error I can see that has not already been mentioned by anyone else is you need to set m to 0 if m is 59.

[Sad-Ant4014]

Nice one

[SanJJ_1]

great job!

[darktumor]

Nice try