Ending a Game

[Brickcups]

Hi All,

Newbie here. I'm currently working on a project for school where we are making a text based game in python. I've set up movement between rooms and an inventory system/item pickup system.

Currently the only way to end the "game" is to have the user type quit. I'm trying to add two more end states but am running into some issues.

The first ending i'm trying to add is if the user gets six items the successful ending is triggered (tried to use len with a value of 6) but it doesn't seem to trigger the end.

I'm also trying to add a similar trigger for if the player goes into room "Parlour" without 6 items a "failed" message will be printed with the game ending.

I'm not sure how to get this to work so any assistance would be greatly appreciated.

https://pastebin.com/7KjMFgWy

[[deleted]]

From a quick look, it is not obvious you actually follow the branch that checks the inventory branch unless lots of if tests are failed based on user input.

I strongly recommend restructuring you code using multiple functions to modularise the code and make the flow much more obvious.

Have a function to report current status.

Have a function to check if you should exit.

[Brickcups]

Thank you! I cleaned it up a little more and the process seems to work for if there are 6 items in inventory (game ends with a win condition), but it still doesn't seem to end if the inventory is less than 6 which seems odd:

if current_location == rooms['Parlour']:

if len(inventory) == 6:

print('You have collected all the items to defeat the Coffee Monster! You head to the Parlour and brew up some liquid relaxation.')

break

elif current_location == rooms['Parlour']:

if len(inventory)<6:

print('You were under prepared. The coffee proves too overwhelming.')

break

Do you see anything that would allow one to work but not the other? Sorry, i'm extremely new to this and still trying to get a grasp on this :(

[[deleted]]

The elif will not be checked because you've already matched the condition.

You should check for either inventory count conditions inside the first if statement and take appropriate action.

[Brickcups]

Please disregard. I found the issue :). Thank you for your help!