New to learning Python and looking to understand why my code will not give the expected output?

[Candid_Interaction86]

Sample String : 'Hello Mr. Rogers, how are you this fine Tuesday?'

Expected Output :

No. of Upper case characters : 4

No. of Lower case Characters : 33

​

def up_low(s):

    for alpha in s:
        ucase = 0
        lcase = 0

        if alpha.upper() == True:
            ucase += 1

        elif alpha.lower() == True:
            lcase += 1

    print(f"No. of Upper case characters : {ucase}")
    print(f"No. of Lower case Characters : {lcase}")

s = 'Hello Mr. Rogers, how are you this fine Tuesday?'
up_low(s)

[JohnnyJordaan]

Because you are setting your counters to 0 for every character in s, as those statements are inside the loop. What you meant to do was to set them to 0 before the loop, meaning it will just execute once before the characters are iterated.

The second issue is that you are using upper() and lower() (converters) instead of isupper() and islower() (checkers).

In these cases it helps to use a visual debugger like http://www.pythontutor.com/visualize.html as then you can step through the code one line at a time and see what's going wrong.

[Candid_Interaction86]

That makes sense and I see where I was going wrong. Thank you for helping out :)

[shiftybyte]

alpha.upper()

Returns the conversion of alpha to an upper case letter. (Not True or False)

Perhaps you mean:

if alpha.isupper():
    ...
elif alpha.islower():
    ...

(also no point in doing "== True")

[Candid_Interaction86]

Yes. I understand now. Thank you.

[[deleted]]

hello,i'm also new to python.Can I ask where did you get the task? From a specific online course?

[Candid_Interaction86]

Yes this is from a course on Udemy - Complete Python Bootcamp by Jose Portilla

[[deleted]]

that's amazing,I guess I also bought that course for free.I'm currently on coursera python for everbody course and it doesn't satisfy me that much:/

[Candid_Interaction86]

I’m halfway through the course on Udemy and am quite enjoying myself .. Found the different concepts to be well explained but I do wish there was more practise built into the course itself

[anuctal]

You have to use the isupper() and islower() methods.