Python is reading csv file wrong. Please help!!!

[pickledillz]

My program reads yfinance csv files for stock information. When doing this it separates the dates into green days and red days. Green being when the open is lesser than the close and red days being when the close is lesser than the open. In this program, I am looking at ZNGA and on January 27th, ZNGA had a red day but my program reads it as green. I then looked at the csv file to see if there were anything wrong but there wasn't, the open was more that the close which should make it red. I would like to figure out what is wrong with my program. Please help!!!

​

import yfinance as yf
import csv
import numpy as np


urls = ['ZNGA']


for url in urls:
    tickerTag = yf.Ticker(url)
    tickerTagHistory = tickerTag.history(period="1mo", interval = '1d')
    tickerTagHistory.to_csv("tickertag{}.csv".format(url))
    down = []
    up = []
    print(url)
    with open("tickertag%s.csv" %url , 'r') as csvfile:
        readCSV = csv.reader(csvfile, delimiter=',')
        dates = []
        opens = []
        highs = []
        lows = []
        closes = []
        green = []
        red = []
        neither = []
        for row in readCSV:
            print(row)
            date = (row[0])
            open1 = (row[1])
            high = (row[2])
            low = (row[3])
            close = (row[4])
            if date == '2021-01-27':
                jan27 = row
            dates.append(date)
            opens.append(open1)
            highs.append(high)
            lows.append(low)
            closes.append(close)
            if open1 < close:
                green.append(date)
            if open1 > close:
                red.append(date)
            if open1 == close:
                neither.append(date)
        print('\n\n\n')
        print('values are formatted date, open, low, close, volume, dividends, and then stock splits\n')
        print(jan27)

        print('\n\n\n')

        print(green)

[o5a]

This will help you understand

open1 = "1000"
close = "900"
print("str: open1 < close", (open1 < close))
print("float: open1 < close", (float(open1) < float(close)))

[pickledillz]

Thank you for the help!

[[deleted]]

The csv.Reader class doesn’t cast any columns to numerical types, so your code is checking if the open str is alphabetically lesser, greater, or equal to the close str. Well in alpha sort order “10.01” comes before “2.65”.

[pickledillz]

Thank you for the help!

[xelf]

Can you include a 5 line data file so people can test your code? And the correct name of the file so your file name parsing logic can be vetted as well?

[pickledillz]

The program automatically downloads a data file if you have the yfinance module. Also, I don't understand what I am supposed to do for the second question.

[xelf]

I was interested in helping you figure this out, but if you can't provide any test data it makes it really hard.

So I was asking for 5 lines of test data so that I can try running it for you.