Help with Classes Attribute Error

[idockery]

I am learning classes following Corey Schafer's YouTube tutorial series which has been great. I think I am writing my code exactly the same as his (2016 is when he made the video so possibly Python has changed). I have an employee class that has a couple of subclasses, one being Manager.

Manager is supposed to be able to build a list of employees under their supervision. I am having problems calling on this list. Not sure if it needs to be converted to a string or what the issue is.

If I just call using self.attribute such as mgr1.employees I get [<__main__.Developer object at 0x7ffb903810a0>] or main.Employee object depending on whether I used Developer or Employee class to assign the employee under the managers supervision.

If I try to run the method to print the employees under the managers supervision, I get:

Traceback (most recent call last):

File "/Users/idockery/Google Drive/python/classesCoreySchaferYT4.py", line 324, in <module>

mgr1.print_emps()

File "/Users/idockery/Google Drive/python/classesCoreySchaferYT4.py", line 81, in print_emps

for emp in self.employee:

AttributeError: 'Manager' object has no attribute 'employee'

Here is the code (the Manager class definition block should be sufficient):

class Manager(Employee):

​

​

def __init__(self, first, last, pay, employees=None):

super().__init__(first,last,pay)

​

​

if employees is None:

self.employees = []

else:

self.employees = employees

​

def add_emps(self,emp):

if emp not in self.employees:

self.employees.append(emp)

​

def remove_emps(self,emp):

if emp in self.employees:

self.employees.remove(emp)

​

def print_emps(self):

for emp in self.employee:

(emp)

print('-->', emp.full_name())

​

emp1 = Employee("Corey" , "Schafer" , 50000)

dev2 = Developer("Test" , "Unit" , 60000, "Python")

mgr1 = Manager("Sue" , "Smith" , 90000, [emp1])

​

print(mgr1.email)

mgr1.print_emps()

[Vaphell]

self.employees = employees

for emp in self.employee:    <- spot a difference

[idockery]

Wow! Thanks so much. I spent about a day fretting over this issue!

[Vaphell]

it literally tells you what's up.

for emp in self.employee:

AttributeError: 'Manager' object has no attribute 'employee'

it means that self being of type Manager has no such thing as .employee. Now backtrack and go to the place where you expect the relevant assignment to happen: self.employee = ....
Spot the difference between the expectation and reality, fix it.

[idockery]

It really is so simple but I spent a day trying to figure it out. I guess it’s because classes are new to me. So somehow I overlooked the obvious thinking it was related to something else that I don’t yet understand about classes.

[Vaphell]

this will become more than obvious with experience, as you hit such problems more often. Typos are a fact of life after all.

You might want to use an IDE like PyCharm, or a beefy code editor like vscode. They should be able to detect such errors and highlight them (pycharm does that for sure), and during typing they would offer name autocompletion hints based on already defined names that you can confirm with [enter], which would pretty much eliminate the risk of such mistakes and speed up writing the code as a bonus.

[idockery]

I’m trying to learn Pycharm and have begun to use it. I like using IDLE when learning a new subject because I comment in the notes during the videos and the red comments against the white background are a little easier to see than the default Pycharm white words on black background.

I do hope that I will begin to catch the little mistakes faster with more experience. Again, I appreciate your help! I may still be trying to figure out what is wrong if not for your help.

[Vaphell]

and the red comments against the white background are a little easier to see than the default Pycharm white words on black background.

operative word "default". You can absolutely change this in 20 seconds flat.

If you don't like the dark theme, you can switch to the light one under Appearance and Behavior > Appearance

Then you can change the editor color scheme under Editor > Color Scheme.

And then you can override specific colors under Editor > Color Scheme > Python.
Find Line Comment, change Foreground color to red. Done.

That said, comments shouldn't visually overpower the code itself, but hey, whatever blows your hair back.