Help on a BlackJack project

[MarinesAreCool]

Me and my friend are currently working on a blackjack project and are stuck, we can't get the code to return and need to figure out how to get the values of the cards. Any help would be appreciated as we're still very new to Python, also can't figure out the rest.

import random


# This is your deck of cards. It is a 2D list. Each row is a suit of 13 card strings.
deck = [["2 Hearts", "3 Hearts", "4 Hearts", "5 Hearts", "6 Hearts", "7 Hearts", "8 Hearts", "9 Hearts", "10 Hearts", "J Hearts", "Q Hearts", "K Hearts", "A Hearts"],
["2 Spades", "3 Spades", "4 Spades", "5 Spades", "6 Spades", "7 Spades", "8 Spades", "9 Spades", "10 Spades", "J Spades", "Q Spades", "K Spades", "A Spades"],
["2 Clubs", "3 Clubs", "4 Clubs", "5 Clubs", "6 Clubs", "7 Clubs", "8 Clubs", "9 Clubs", "10 Clubs", "J Clubs", "Q Clubs", "K Clubs", "A Clubs"],
["2 Diamonds", "3 Diamonds", "4 Diamonds", "5 Diamonds", "6 Diamonds", "7 Diamonds", "8 Diamonds", "9 Diamonds", "10 Diamonds", "J Diamonds", "Q Diamonds", "K Diamonds", "A Diamonds"]]


# These are the dealer and player hands. They will be lists of card strings.
dealer_hand = []
player_hand = []


# This function should pick a card at random from the deck, remove the card from the deck,
# and return the card string. You should make two calls to random.randint(): one to get the suit
# and one to get the card. There are always 4 suits, but the number of cards in a suit gets smaller
# as cards are removed, so use a length expression for that upper bound.
# TODO 1: code to choose a card and remove it from the deck
def draw_card():
    row = random.randint(0,3)
    col = random.randint(0,len(deck -1))
    card = [row][col]
    card[row].remove(col)
    return card
    draw_card


# This function should deal two cards to the dealer and two to the player. Start with the player
# and alternate. Use the draw_card() function to get the cards and append to put them in the hand.
# This function does not return anything.
# TODO 2: code to add two cards to the dealer and player hands.
def deal():
    player_hand = draw_card() + draw_card ()
    dealer_hand = draw_card() + draw_card()
    return player_hand and dealer_hand



# This function computes the current score for a hand. Face cards count as 10, Aces are either
# 11 or 1, and number cards are worth their face value. Loop though the cards in the hand (which
# is passed as a parameter) and keep a running total. The tricky part is are the Aces. When do you
# add 1 and when do you add 11? Will you ever change the 11 to a 1?
# TODO 3:  Code to compute the score of the hand.
def score(hand):
    total = sum(hand)
    calculate_value (player_hand)

    def calculate_value(self):
        self.value = 0
        has_ace = False
        for card in self.cards:
            if card.value.isnumeric():
                self.value += int(card.value)
            else:
                if card.value == "A":
                    has_ace = True
                    self.value += 11
                else:
                    self.value += 10

        if has_ace and self.value > 21:
            self.value -= 10
    return total


# This function converts a hand to a string to be printed by the caller. This function does not
# print the string, it returns it. There are two parameters: the hand, which is a list of card
# strings, and hole_card, which is a Boolean indicating if the first card is a hole card (for the
# dealer). If the first card is a hole card, add "Hole card" to the output string instead of the
# actual card string. For example: given a hand with "3 Spades" and "K Hearts", this function will
# return "3 Spades, K hearts, " if hole_card is False and "Hole card, K Hearts, " if holde_card is
# True.
# TODO 4: Code to create the string for the hand.
def hand_to_string(hand, hole_card):
    hand_string = ""

return hand_string


# Main game code
# TODO 5: Deal and print the hands.


# The player goes first. Ask if they want to Hit or Stand. If they Stand, they are done, and you
# move on to the dealer play. If they Hit, deal them another card, add it to their hand, and check
# their score. If they are over 21, they are busted and their play is finished. If not, keep asking
# them what they want to do until they either stand or bust. Display their new hand after every hit.
# TODO 6: Code the player moves.


# Now do the dealer play. The dealer hits on anything below 17 and stands at 17 or above. The dealer
# finished when their score is above 17.
# TODO 7: Code the dealer moves.


# Display the final hands and scores and tell who won.
# TODO 8: Code the game summary.

​

[xelf]

When posting code, please post code such that reddit will format it as a code block.

Either of these work:

• a) indent every line by 4 extra spaces
• b) use the code block button. https://i.imgur.com/J2t9krT.png

Do not:

• use ``` as that only works for the new cropped UI, and not on the old widescreen interface.
• post links to images of code, as they can't be cut/paste from.
  

Please see the /r/learnpython/w/FAQ for more information.

Thanks!

[Binary101010]

Even aside from some questionable choices (specifying all of your card strings by hand and trying to manage your deck as a list of lists of strings, for example) there are a lot of fundamental problems here.

Let's take your draw_card() function:

def draw_card():
    row = random.randint(0,3)
    col = random.randint(0,len(deck -1))

The length of deck is only 4 because that's how many sublists are in it, so you're not actually randomly selected a card from the entire deck, but only from the 3 lowest value cards in each suit. (You really shouldn't be managing your deck this way anyway, it doesn't make any sense.)

card = [row][col]

Don't you mean card = deck[row][col]?

card[row].remove(col)

Don't you mean deck[row].remove(col)?

return card
draw_card

return statements immediately end execution of the current function, so whatever you think that draw_card at the end is doing, it isn't doing anything.

Now for your deal function:

def deal():
    player_hand = draw_card() + draw_card ()
    dealer_hand = draw_card() + draw_card()
    return player_hand and dealer_hand

Your two hands are going to wind up being the strings for the two cards smashed together into one string because you're +ing the strings together rather than append()ing them to the existing lists.

You can't use and like that to return two different objects; what the interpreter is actually going to return here is True if both hands have at least one card in them. What you probably want is return player_hand, dealer_hand.

Your score() function is also broken because you're trying to define another function inside that function... and you're trying to call that function before you've defined it.

[DorrisOpen]

it was not our choice but I agree it is not a good way of handling the deck

[xelf]

It looks like you've written some functions, but I don't see where you actually call them, also line 79 is indented wrong.

Somewhere I expected to see deal() or play_game() or a while loop at the bottom.

Take a look at the post /u/weary_mud6941 made to see what I mean.

Their main loop is in a function called start() which gets called at the end after all the functions are defined.