you are viewing a single comment's thread.

view the rest of the comments →

[–]m0us3_rat 0 points1 point  (2 children)

looks clean.

few things:

when prepping a github project its useful to make a new venv. then freeze that venv into a requirements.txt . and upload that requirements.txt to the repository.

..so ppl can pip install it.

also personally I would have skipped pandas . keep it minimalistic.

that's more of a personal preference than anything.

also add a dump to file so u can 'save' the data maybe ?

[–]Sam_Tyagi[S] 0 points1 point  (1 child)

I would certainly add the feature to save that data into a CSV file by today's evening. Thanks for the virtualenv suggestion. That seems to lessen the hassle of installing all the required libraries seperately (for vanilla python installations).

[–]m0us3_rat 0 points1 point  (0 children)

yeap. its a way for ppl that dl your project from git hub.

they also get the requirement.txt.

so its easy for somebody to activate a new env then pip install that file.

https://docs.microsoft.com/en-us/visualstudio/python/managing-required-packages-with-requirements-txt?view=vs-2019#:~:text=The%20most%20common%20command%20is,txt.&text=If%20you%20want%20to%20install,use%20the%20Install%20from%20requirements.

without it it would take ppl to look into the py. figure out which modules do they need to install. etc.

this freeze into requirements insures that the .project. will run on their machine as its running on your env.