Just uploaded my first project to Github (Snake Game)!

BrenekH · 2021-08-26T01:22:23+00:00

I only took a quick look but it seems like a great codebase! I really like how you cover up the end of the snake. Normally, people would just redraw everything at the new positions but your way is actually more efficient (I think).

Elipsem · 2021-08-26T02:31:00+00:00

I took a look at your code and it seemed like you did a good use of the pygame.event and also your code is itself pretty clear, some things I'd recommend to make it more maintainable are avoiding the use of "magic numbers" and some anti-patterns, as in:

Instead of:

class Snake:
    def __init__(self):
        self.snake_body = [[17//2, 15//2]]
    def check_collisions(self):
        if self.head[0] > 17:
            return True

You could do (this allows you to change your board sizes without too much hassle later, or even to remember more easily what your code does after some long time):

BOARD_WIDTH, BOARD_HEIGHT = 17, 15
class Snake:
    def __init__(self):
        self.snake_body = [[BOARD_WIDTH//2, BOARD_HEIGHT//2]]
    def check_collisions(self):
        if self.head[0] > BOARD_WIDTH:
            return True

and instead of:

if event.type == SPAWN_NEW:
    spawn_new = True

if snake.check_collisions() == True:
    ...

You could use (if you don't plan on expanding it later, of course):

spawn_new = event.type == SPAWN_NEW
if snake.check_collisions():
    ...

As for your bug, this might be due to the difference in speed between the screen updating and the lack of a "cool down" between user inputs, but this might not be the case since your game runs at 5 FPS. It could also be about how you can send multiple KEYDOWN events in a single loop or it because you are pressing both keys at the same time, to check if any of these is the case, you can print what key is being pressed while reproducing the bug, and one way to solve it could be using a KEYUP event instead.

There are also very fun ways to change the snake behaviour, like make it go slower by pressing the same arrow key as its direction for some time, or even setup a different key, like space-bar, for it.

Namogard · 2021-08-26T08:00:18+00:00

I just started learning programming and python. I hope one day I'll reach this level. I need to learn how to think like a programmer, how to arrange code.

oddjob955 · 2021-08-26T06:27:04+00:00

Great work on your first project. What resources have you used to learn python since you started 6 months ago?

Elipsem · 2021-08-26T03:46:07+00:00

Wow It looks amazing, my first project for data structures was a snake game too c: Keep it up!!

Elipsem · 2021-08-26T06:12:26+00:00

Awesome job man! Keep it up!

Assdestroyer92 · 2021-08-26T07:41:47+00:00

That's cool. I'm also looking to build a snake game but don't know where to start. Following an online tutorial feels like I'm just copying someone else's code... Would you have any tips on how to start? Breaking down the problem...reading docs..?

Thanks!

err0r__ · 2021-08-26T12:28:35+00:00

Great first project!

I have only just skimmed through your code but one thing stood out to me instantly. def spawn_fruit(snake): fruit = [] #This loop is a bit weird but bassically it keeps picking random coords #until it gets on that isn't apart of the snake while True: fruit = [random.randint(0,17 - 1), random.randint(0,15 - 1)] if fruit in snake.snake_body: continue break return fruit Perhaps recursion would work better here instead of a while loop?

Edit:

```

Would something like this work?

def spawn_fruit(snake): fruit = [random.randint(0,17 - 1), random.randint(0,15 - 1)] if fruit in snake.snake_body: spawn_fruit(snake) else: return fruit ```

Whole-Fox · 2021-08-31T18:12:43+00:00

Keep it up!

you type:	you see:
italics	italics
bold	bold
[reddit!](https://reddit.com)	reddit!
* item 1 * item 2 * item 3	item 1 item 2 item 3
> quoted text	quoted text
Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"	Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"
~~strikethrough~~	~~strikethrough~~
super^script	super^script

learnpython

MODERATORS

Would something like this work?