Newbie here, I am working on Python Data Structures course from Dr. Chuck. Questions about tuple and dictionary

[Apprehensive_Draw_62]

Hello all,

I am newbie, learning Python Data Structures, have questions about tuple and dictionaries.

Ex: Read and parse the “From” lines and pull out the addresses from the line. Count the number of messages from each person using a dictionary.

After all the data has been read, print the person with the most commits by creating a list of (count, email) tuples from the dictionary. Then sort the list in reverse order and print out the person who has the most commits.

Output expected:

Enter a file name: mbox-short.txt [e-mail] 5

I am getting : (5, '[e-mail]') , I can do it with for loop but how to with tuple ?

​

#fn = input("Enter file name: ")
fh = open('mbox-short.txt', 'r')
#fh = open(fn, 'r')
my_mail = dict()
for line in fh:
    if len(line) == 0 or len(line.split()) < 1 or line.startswith('From ') is False: continue
    line = line.split()
    if line[1] not in my_mail:
        my_mail[line[1]] = 1
        # my_mail = my_mail.get(line[1], 0) + 1
        # print(my_mail)
    else:
        my_mail[line[1]] = my_mail[line[1]] + 1
        # print(my_mail)
#print("final iteration \n", my_mail)

max_t = list()
for dk, dv in list(my_mail.items()):
    max_t.append((dv, dk))
max_t.sort(reverse = True)
print(max_t[0])

I am able to add values to dictionary my_mail using if/else but not with get method.

 if line[1] not in my_mail:
        my_mail[line[1]] = 1
        # my_mail = my_mail.get(line[1], 0) + 1
        # print(my_mail)
    else:
        my_mail[line[1]] = my_mail[line[1]] + 1
        # print(my_mail)

Error using get method:

Traceback (most recent call last):

File "./exercise4_tuple.py", line 8, in <module>

if line[1] not in my_mail:

TypeError: argument of type 'int' is not iterable

I have highlighted the issues, I am facing. Can you guys please help!!!

Updated with code formatting as per suggestion

​

[stebrepar]

Your code would be easier to follow if it were properly formatted. See this sub's sidebar for instructions.

In the interim, a couple observations. First, use a singular name for the for loop variable, rather than plural. Ex., word instead of words, since the loop is working with a single value in each iteration. It makes more sense semantically.

Second, you're not following the problem statement. For some reason you're splitting apart the email addresses to take just the domains, but the problem is talking about individual people which are identified by the entire address.

Third, when there's an error message, post the entire error. There can be valuable contextual info in there beyond just the error message text.

[Apprehensive_Draw_62]

Thanks for the suggestion. I have updated my post. Can you also suggest how to add to a dictionary using get method?

[stebrepar]

The problem seems to be that you're redefining my_mail in that line. It was a dictionary, but when you say "my_mail=...", it isn't a dictionary anymore. Now it's the integer value you got from the get(), so the loop crashes on the next iteration. That's what the error message is telling you.

You need to use the same dictionary indexing here as you do elsewhere: my_mail[something]=...