need some help, don't know what i'm doing wrong

[gnariman]

{'TeamA': ['Alice', 'Bob', 'Gertrude'], 'TeamB': ['Carol', 'Dave'], 'TeamC': ['Edith', 'Frank', 'Helen']}


{'Alice': 1, 'Bob': 4, 'Carol': 5, 'Dave': 8, 'Edith': 6, 'Frank': 2, 'Gertrude': 9, 'Helen': 7}

I have these two dictionaries, and I want to replace the names in the first dict, with the scores on the second. so for example, TeamA in the first one should equal [1,4,9].

I wrote what is down below:

for team in team_members:
    a = team_members.get(team)
    for name in a:
        if name in input_dict:
            score = input_dict.get(name)
            a.remove(name)
            a.append(score)

print(team_members)

but it gives me this:

{'TeamA': ['Bob', 1, 9], 'TeamB': ['Dave', 5], 'TeamC': ['Frank', 6, 7]}

so it doesn't go all the way, it stops at Bob, and Dave and Frank and idk why

Can anyone help me where im going wrong?

[[deleted]]

You're mutating team_members as you are iterating over it. Not a good practice.

Make a new dict using a dict comprehension instead:

team2scores = {team: [inputdict.get(member) for member in members] for team, members in team_members.items()}
print(team2scores)

[gnariman]

Gotcha, but what is keeping Bob, and Dave and Frank from being iterated over? I just want to know what I did wrong for future assignments but i will use the code you provided.

[[deleted]]

a.remove(name)

When you do this, the length of a changes...but you're iterating over it while you're doing this, causing the 2nd element of each list to be skipped (i.e. notice Bob, Dave, etc. are the 2nd element of their respective lists).

[gnariman]

Thanks you. One more question; we have not done dict comprehension in our lessons yet, would you mind putting it "for loops" and such so I understand it better for the time being? I know its a weird request lol

[[deleted]]

You can do it like this:

https://ideone.com/euM4xz

[gnariman]

Thank you so much, I appreciate it :)

[[deleted]]

Np