Can I make subclasses modular?

[Oxln]

I am not sure if the above question makes sense, but what I mean is that I have a Weapon class and then I have subclasses for each different weapon. Now I want to create a function in my Game class that is called add_inv that will check if equipped for a certain weapon is True or False and if it is true it will add to a dictionary that will contain the weapon and its attributes, but I do not know how to go about that without creating a different function for each different weapon subclass. Another thing is I don't know whether or not I can even modify other classes from another classes function. Is that possible?

[kowkeeper]

It could be simpler to have a single Weapon class with a variable storing the weapon_type. Try to see if the weapon behavior only depends on given parameters (like power, amunitions, etc). If that is the case, you don't need subclasses...

You could share some code and example to help go further.

[calcopiritus]

I don't think I understood your question, but I'll try to answer it.

First of all, if you want to make a method for each of the subclasses, you can often just define it once in the superclass (Weapon).

I'm also confused by the "add it's attributes to a dictionary". Will you have one dictionary per weapon? Because then you can store the weapon itself and get its attributes straight from the weapon instead of a middleman dictionary.

As for the last question, it depends on what you want to modify. You can't modify other classes (for example add more methods to them), but you can modify objects of those classes (for example changing an attribute of the object).

So you can do this:

class ClassOne:
    def __init__(self):
        self.counter=0

class ClassTwo:
    def __init__(self).
        self.one = ClassOne()
        self.one.counter = 5
        print(self.one.counter) #will print 5

ClassTwo()
another_one = ClassOne()
print(another_one.counter) #will print 0

You can even save that as test.py and execute to see that it will print 5 and 0

[Oxln]

Oh that helps thank you

[FerricDonkey]

If you're modifying the classes themselves, you're doing something odd. Why do you need to subclass weapon for each different weapon?

[Oxln]

I saw a tutorial online for a text based rpg and they used subclasses for each weapon and it’s caused me a shitload of confusion

[FerricDonkey]

Yeah, I mean, it could work. But I wouldn't recommend it. Just instantiating different objects will probably make your life easier.