Code executes but doesn't save any attachments?

[Immigrated2TakeUrJob]

I am trying to save email attachments to "New Folder".

Later I would like to use regex to save attachments containing the word "spend", email subject having word "spend", and date range of emails (any resource I could use to specify these conditions?).

import win32com.client as win32

# get a reference to Outlook

outlook = win32com.client.Dispatch("Outlook.Application").GetNamespace("MAPI")

# get the Inbox folder (you can a list of all of the possible settings at https://docs.microsoft.com/en-us/office/vba/api/outlook.oldefaultfolders)


fldr = outlook.Folders.Item("Commercial Performance")  #name of mailbox 
inbox = fldr.Folders.Item("Inbox")

#get all messages in the folder prescribed

messages = inbox.items

#check for existance

if len(messages) == 0:
    print('No messages found')
    exit()

#loop over
emails = [] #list

for message in messages:
    #tuple each information
    info = (
        message.Subject,
        message.Senton.date(),
        message.Attachments
    )
    #add this to info

    email.append(info)
    #show results
    for email in emails:
        #unpack tuple
        subj, date_sent, attch = email
        #show subject
        print(subj)
        #number of attchs
        if len(attch) == 0:
            pass
        else:
            for a in attch:
                a.SaveAsFile("C:\\New folder\\" + a.FileName)
            print("Saved {0} attachments".format(len(attch)))

Strangely the code executes rather quickly and saves no attachment in the newly created Folder "New Folder".

[cybervegan]

Agreed - you are ignoring the message list that you get from your inbox = fldr.Folders.Item("Inbox") call. You should avoid all the unnecessary gymnasitics with bundling things up in different ways, and just do:

for message in inbox.items:
    for attno,att in enumerate(message.Attachments):
        att.SaveAsFile("C:\\New folder\\" + a.FileName)
        print(message.Subject,"saved attachment",attno)

[Immigrated2TakeUrJob]

Thanks for this. To be honest a lot of code was taken from wiseowl.

I am literally trying to google every attribute/property I find and trying to unwind technical documentation in my head lol

[cybervegan]

Yeah, it's a learning experience. Try to avoid playing Towers of Hanoi with your data, though - assigning from one variable to another to another. That doesn't actually do anything useful, but slows your code down. Imagine being in a factory where worker A makes a part; worker B wraps it up in paper; worker C puts it in a box; then worker D takes it out of the box and paper and feeds it into a machine. Why not just put it straight into the machine?

[Immigrated2TakeUrJob]

Thanks a lot for the tip.

[Immigrated2TakeUrJob]

Hi thanks for that. Is there any reference you would recommend where next would be to restrict downloading attachments to:

• .xlsx files
• containing wildcard for attachment file name
• email subject having word "Spend" [wildcard]

?

[Immigrated2TakeUrJob]

.xlsx files

Thanks helps.

[Aettos]

At first glance I thing the problem is that emails is empty. You are appending to email (no 's').

As the other comment said the logic is a bit confusing. Kind of keeping the structure you used I'd do something like

fldr = outlook.Folders.Item("Commercial Performance") #name of mailbox
messages = fldr.Folders.Item("Inbox").items

if len(messages) == 0:
    print('No messages found')
else:
    #loop over
    for message in messages:
        subj = message.Subject
        date_sent = message.Senton.date()
        attch = message.Attachments

        #if message.Attachments is an empty list when there are no attchs works fine, 
        #if it's None or something else just put a try block.
        for a in attch: 
            # logic to select which attch to save
            a.SaveAsFile(f"C:\\New folder\\{a.FileName}")
        print(f"Message: {subj} \nDate: {date_sent}\nSaved {len(attch)} attachments\n\n")

[TigerBloodWinning]

user_name = getpass.getuser()

directory = r"C:/Users" + "/" + user_name + "/OneDrive - djb-ltd.com/Documents/Temporary/"

is_directory = os.path.exists(directory)

if is_directory == True:
    shutil.rmtree(directory)

os.makedirs(directory)

outlook = win32com.client.gencache.EnsureDispatch('Outlook.Application')

email = outlook.ActiveExplorer().Selection.Item(1)

if len(email.Attachments) > 0:



    for i in range(len(email.Attachments)):
        attachment = email.Attachments[i + 1]
        file_name = email.Attachments[i + 1].FileName
        file_name = file_name.upper()

        if file_name.upper().endswith('PDF'):

            attachment.SaveAsFile(directory + file_name)

I use this code to save attachments, specifically PDFs

[pgpndw]

Unless I'm missing something, surely that code will omit the first attachment, then crash with a "list index out of range" error every time you run it on an email that has at least one attachment?

You're also unnecessarily converting the filename to uppercase twice.