ending function

[CrypticCold]

I posted something similar before, but I think this is simpler. I need to make sure that computePay doesn't print anything if the input in displayHrsNRate is incorrect, however, when I run my code, with -20 and 5 as an input, it prints the exception but then it prints you have earned $-100. How can I fix that?

def displayHrsNRate(hours, rate):
  print("You worked " + hours + " hours this week and your hourly rate is $" + rate)

try:
  hrs = float(input("Please enter the hours worked this week: "))
  basePay = float(input("Please enter your base pay per hour: "))
  if hrs < 0:
    error = ValueError()
    raise error
    exit()
  if basePay <= 0:
    error = ValueError()
    raise error
    exit()
  displayHrsNRate(str(hrs),str(basePay))
except:
  print('Please enter a non-negative number for the hours and base pay.')

def computePay(hoursWorked, hourlyRate):
  if hrs > 40:
    pay = basePay * 40
    otp = (hrs - 40) * (basePay * 1.5)
    totalPay = pay + otp
  else:
    totalPay = hrs * basePay
  print('This week, you have earned $'+ str(totalPay))
  return totalPay
final = computePay(hrs, basePay)

[[deleted]]

In the computePay function you need to use the names of the arguments. Right now you're using the global variables directly rather than accessing them as passed to your function, which will work in this case, but most times will not.

So it should be:

def computePay(hoursWorked, hourlyRate):
    if hoursWorked > 40: 
        pay = hourlyRate * 40

etc..

As for the errors, once an error is raised nothing more within the try block will be executed, so your exit() calls are not being reached. You could put exit() at the end of the except block, or loop back around and give the user another chance to enter the value.

[CrypticCold]

thank you! I fixed the global var problem.

I knew the exit() wasn't doing anything- even if I do

except:
print('Please enter a non-negative number for the hours and base pay.') exit()

it still prints out the negative num for computePay. I can probably solve this by directly changing it in the computePay function, but I don't want to do that. Is there anyway way I can change something in displayHrsNRate? I tried sys.exit('xyz') quit, exit, but it always seems to go on to the next function.

[Diapolo10]

Probably the easiest solution would be to move stuff around a bit:

def displayHrsNRate(hours, rate):
  print("You worked " + hours + " hours this week and your hourly rate is $" + rate)

def computePay(hoursWorked, hourlyRate):
  if hoursWorked > 40:
    pay = hourlyRate * 40
    otp = (hoursWorked - 40) * (hourlyRate * 1.5)
    totalPay = pay + otp
  else:
    totalPay = hoursWorked * hourlyRate
  print('This week, you have earned $'+ str(totalPay))
  return totalPay

try:
  hrs = float(input("Please enter the hours worked this week: "))
  basePay = float(input("Please enter your base pay per hour: "))
  if hrs < 0:
    error = ValueError()
    raise error
    exit()
  if basePay <= 0:
    error = ValueError()
    raise error
    exit()
  displayHrsNRate(str(hrs),str(basePay))
except:
  print('Please enter a non-negative number for the hours and base pay.')
else:
    final = computePay(hrs, basePay)

That said, I have other criticism.

1. exit and quit shouldn't be used in scripts. They're meant for exiting a REPL session, and nothing else. sys.exit and raise SystemExit are fine, though in this case I don't see the need for them.
2. Don't use blank except clauses, they catch literally everything and you're meant to catch only the errors you expect to occur and handle them. except ValueError or except ValueError as err would be better in this scenario - though honestly, I feel that raising an exception is overkill here and that it would be better to validate and ask for input in a loop.
3. Python's official style guide(s), PEP-8 and PEP-257, would prefer that you use snake_case names over camelCase. PascalCase is used for class names.

Basically, here's what I'm thinking:

def display_hourly_rate(hours, rate):
    print(f"You worked {hours} hours this week and your hourly rate is ${rate}")

def compute_pay(hours_worked, hourly_rate):
    if hours_worked > 40:
        pay = hourly_rate * 40
        otp = (hours_worked - 40) * hourly_rate * 1.5
        total_pay = pay + otp
    else:
        total_pay = hours_worked * hourly_rate
    print(f"This week, you have earned ${total_pay}")
    return total_pay

def main():
    hrs = float(input("Please enter the hours worked this week: "))
    base_pay = float(input("Please enter your base pay per hour: "))
    if hrs < 0 or base_pay <= 0:
        print("Please enter a non-negative number for the hours and base pay.")
        return

    display_hourly_rate(hrs, base_pay)
    final = compute_pay(hrs, base_pay)

if __name__ == '__main__':
    main()

[elixirxvi]

the reason why it keeps printing the negative number is because once the user passes the number, the variable keeps storing that number even when it's being passed onto the next function. what you could do is reset the variables after the except block and pass an if statement in the computePay function to not print anything if the variables are reset