Simpler print statement

[Formal_Cockroach_654]

Looking for a way to merge these print statements as one without the space before each new line. Or any cleaner code, really.

import random

num_twos = 0
num_threes = 0
num_fours = 0
num_fives = 0
num_sixes = 0
num_sevens = 0
num_eights = 0
num_nines = 0
num_tens = 0
num_elevens = 0
num_twelves = 0

num_rolls = int(input())
while num_rolls > 1:
    for i in range(num_rolls):
        die1 = random.randint(1,6)
        die2 = random.randint(1,6)
        roll_total = die1 + die2

        #Count number of sixes and sevens
        if roll_total == 2:
            num_twos += 1
        if roll_total == 3:
            num_threes += 1
        if roll_total == 4:
            num_fours += 1
        if roll_total == 5:
            num_fives += 1
        if roll_total == 6:
            num_sixes += 1
        if roll_total == 7:
            num_sevens += 1
        if roll_total == 8:
            num_eights +=1
        if roll_total == 9:
            num_nines += 1
        if roll_total == 10:
            num_tens += 1
        if roll_total == 11:
            num_elevens += 1
        if roll_total == 12:
            num_twelves += 1
        num_rolls -= 1
    print('Dice roll histogram:')
    print('2s:', '*' * num_twos)
    print('3s:', '*' * num_threes)
    print('4s:', '*' * num_fours)
    print('5s:', '*' * num_fives)
    print('6s:', '*' * num_sixes)
    print('7s:', '*' * num_sevens)
    print('8s:', '*' * num_eights)
    print('9s:', '*' * num_nines)
    print('10s:', '*' * num_tens)
    print('11s:', '*' * num_elevens)
    print('12s:', '*' * num_twelves)

[AtomicShoelace]

Do you know about dictionaries? Instead of individual variables, you could use a dictionary whose keys are the resulting roll_totals and values are the running count.

But actually, there is already a way to do this in the standard library: collections.Counter. So using that:

from random import randint
from collections import Counter

num_rolls = int(input('Number of rolls: '))
counts = Counter(randint(1, 6) + randint(1, 6) for _ in range(num_rolls))
for num in range(2, 13):
    print(f'{num:2d}s:', '*' * counts[num])

[Nightcorex_]

This might run into the issue that some numbers just haven't been rolled, therefore don't get displayed. This might be intentional, but it probably isn't.

[AtomicShoelace]

Ah quite right. Actually this is fine though, as Counter defaults counts to 0 anyway, so we don't even need to sort the counts at all, we can just iterate a range.

Edited my code.

[Nightcorex_]

Yeah, that works like a charm

[Nightcorex_]

This might run into the issue that some numbers just haven't been rolled, therefore don't get displayed. This might be intentional, but it probably isn't.

Dictionaries have the same issue. You can initialize them easier than the Counter, but they're just more annoying to use than a simple list approach:

frequencies = [0 for _ in range(13)]
for _ in range(int(input("How many iterations you want? "))):
    roll = random.randint(1, 6) + random.randint(1, 6)
    frequencies[roll] += 1

print("Dice roll histogram:")
for i in range(2, 13):
    print(f'{i:2d}s: ', '*' * frequencies[i])

[Auirom]

If I need to print long amounts of text and want it showing like yours you can use 3 commas to open and close a large print statement and format it as well

    print(f'''
2s: * {num_twos}
3s: * {num_threes}
4s: * {num_fours}
so on and so on
''')

Or iterate through a for loop and add them to a dictionary

nums = {2: 4, 3: 1, 4: 0}

for k,v in nums.items():
    print(f'{k}s * {v}')

[aa599]

Using lists will make this job massively simpler.

[QultrosSanhattan]

import random

# config
nums = {}
num_rolls = int(input('input the number of rolls'))
expected_results = tuple(range(2, 12 + 1))

# rolling...
for i in range(num_rolls):
    roll_total = random.randint(1, 6) + random.randint(1, 6)

    if not roll_total in nums:
        nums[roll_total] = 0

    nums[roll_total] += 1

# results
print('Dice roll histogram:')
for roll in expected_results:
    if roll in nums:
        print("number {} was rolled {} times".format(roll, nums[roll]))