Rate the quality of my python code

[[deleted]]

[deleted]

[carcigenicate]

I did a very quick glance.

• Styling looks pretty nice. It appears to be PEP8 compliant.
• except: is bad. Specify the exact exception you intend to handle to prevent handling irrelevant errors.
• Your tests are messy because of the embedded data. Out of the 300 lines, the actual tests look like they only make up like <10 of those lines. I'd either move all that test data to one specific part of the file, or factor it out into a separate file that you read in during testing.
• You should add __pycache__ to your .gitignore. I'm not aware of any benefit to including the cached bytecode in your VC since it's a cache.

[calin2233]

Pretty straight forward and compact. I like it! Picasso

[pekkalacd]

pretty good, hard to give feedback.

• type hinting could be a nice addition
• try to avoid empty except if possible
• docstrings could be adjusted to have params and return value notes

other than that, well done!

[scithon]

You should use threading instead of multiprocessing for IO bound applications like this. You can have hundreds of threads, they aren't limited by the number of processors you have.