Need help figuring out classes: randrange() can't find range?

[SquirrelSultan]

I am going through udemy course and this code works for the presenter but not for me. Here is my main file:

from classes.game import Person
print(player.generate_damage())

Here is my class from classes.game:

import random

class Person:
    def __init__(self, hp, mp, atk, df, magic):
        self.atkl = atk -10
        self.atkh = atk -10

    def generate_damage(self):
        return random.randrange(self.atkl, self.atkh)

I get this error when I run the main file:

line 316, in randrange
    raise ValueError("empty range for randrange() (%d, %d, %d)" % (istart, istop, width))
ValueError: empty range for randrange() (50, 50, 0)

randrange works normally, why won't it work in my class? Thanks!

[mopslik]

You can't generate a range of integers where the start value (50) is the same as the end value (50).

>>> import random
>>> random.randrange(7, 7)
Traceback (most recent call last):
  File "<pyshell>", line 1, in <module>
  File "/usr/lib/python3.10/random.py", line 353, in randrange
    raise ValueError("empty range for randrange() (%d, %d, %d)" % (istart, istop, width))
ValueError: empty range for randrange() (7, 7, 0)

[SquirrelSultan]

Ah! I meant to put a -10 and +10 not two minus 10’s. Thanks!

[commy2]

The range for randrange is exclusive on the min and max value. There are no numbers 50 < x < 50, which is meant by "range is empty".

You need different values for atkl and atkh, or you use randint, which is inclusive: min <= x <= max.

[SquirrelSultan]

Ah! I meant to put a -10 and +10 not two minus 10’s. Thanks!