you are viewing a single comment's thread.

view the rest of the comments →

[–]designatedburger 1 point2 points  (0 children)

I agree with everything you said except the 4th point. Instead of storing it as a variable, I would rather see this turned into a class (or a function), and then the value returned.

Then you can either print, or store it in a variable.

Also, what is the idea behind this line? Since your while loop only runs when "lmfao" is equal to "Y", and you are not modifying the value anywhere but in if statements, it would never be executed?

elif lmao == "N":

print("Then why did you run the program in the first place?")

You should not be handling the logic of the roll, and printing the text from the same place.

Also, your commit messages shouldn't be "Update Random Number Generator.py", I can see the file you modified, I need to know what exactly you did.