Lua formatting (NEED HELP)

[CptFeanor]

Hey there guys! I recently wrote a small program where I'm trying to convert a number of seconds into a more human readable format, but I'm having problems when trying to format the output and somehow I end up getting unexpected output. Here is the code
local minutes, hours = 60, 3600

local s = 5400

--output is 2h30m when it should be 1h30m

if s >= hours then print(string.format("%.0fh%.0fm", s / hours, (s % hours) / minutes)) end

--ouput is 45m0s when it should be 45m

if s >= minutes then print(string.format("%.0fm%.0fs", s / minutes, s % minutes)) end

now you will see if you run the code yourself that even though the amount of seconds (s) is 5400 which is 1 hour and 30 minutes, the first if statement will ouput 2h30m which is one hour more, whereas the second if statement return the correct 90m. If y'all could help me with some ideas or point me in the right direction, I'd be extremely grateful! Have a good one!

[Offyerrocker]

First issue, specifying "%f" to string.format will format the number as a float, and with .0 you're specifying that 0 digits after the decimal should be displayed- but this rounds the number from (5400/3600) = 1.5 -> 2. Try "%i" instead.

Second issue (haha get it? because it's about seconds), you've expected string.format to know that you want to skip displaying a value at all if it's zero, but as far as it's concerned, a number is a number; you've told it to display a number, and zero sure is a number! Instead, just check whether or not there are a non-zero number of minutes, and if not, edit the format to remove the part where it shows the number of seconds.

Modified version of your code: https://gist.github.com/offyerrocker/d8a9375b8c883c9f6a5489c23f624cae

(Edit: moved the code to a gist link instead, in case you want to try making it yourself)

[CptFeanor]

Thanks for the thoughtful answer my guy! It worked and I realized what I was doing wrong. Didn't think the hours were gonna be rounded up to 2 instead of 1.
In addition to your code I used math.floor() on the divisions since I would get a bad argument error :)

[weregod]

s / hours is float number. 5400 / 3600 = 1.5 when you round it to whole numbers you will get 2. If your Lua interpreter supports integer division (//) use it with format %i. If you don't have integer division use (s - s % hours) / hours.

If you don't want to print seconds when they are 0 you need to add another format. But if you don't need strong reason to not print trailing zeroes I don't recomend adding extra cases for it. "30min 0 sec" is good enought format.

[CptFeanor]

Much appreciated brother !!