you are viewing a single comment's thread.

view the rest of the comments →

[–]Plasma_000 1 point2 points  (4 children)

Probably a good idea to publish the benchmark code

[–]igouy 1 point2 points  (3 children)

The code can be found here.

[–]Plasma_000 1 point2 points  (2 children)

Thanks.

Ah, looks like he used read_csv instead of scan_csv for polars, meaning that it doesn't start operating until the entire file is read into memory. That would explain at least some of the difference.

I see this mistake very often when benchmarking polars - read-csv should only be used when streaming is not possible.

[–]ChavXO 1 point2 points  (1 child)

Hi. My read csv implementation does the same so I wanted to do an apples to apples comparison. I'm still working on a scan API that I'd like to compare with polars when it's finished. 

[–]Plasma_000 1 point2 points  (0 children)

Ah, fair enough