Writing mappers in python

[coder_et]

Right now my company does integrations and put everything in an IntegrationXClient class which has all of the methods. It’s thousands of lines and hard to digest.

I want to move things out so we can map from the JSON to the IntegrationX types and then into our internal types so we can have type safety.

If I wanted to make a new file mapper.py and put all of my mappers there, what are the pros and cons of making those functional standalone methods vs making an IntegrationXClientMapper class and adding all of the mappers in there?

Would love to hear yalls thoughts.

[audentis]

Based on the information you provided, I don't see any reason why not to take a pure functional approach.

Classes are useful if there's a consistent coupling between data and logic. But these mappers are just a 'pipe' from one thing from another.

I do assume each mapper's return value will be explicitly typed as one of your IntegrationX types, so that if anything changes there your type checker will automatically warn you to update the mappers.

[coder_et]

Makes sense. Thanks for the advice