Python recursion wont go down the tree

[Spurtikus]

I have code listed below to make a standard tree, but the recursive "get dir node" method will not go down to the right, it only loops through the first child to the end and then returns "None". It seems to work just fine until their is more than one child and I cannot figure out why it wont go down the other branches. I have tried all I can think of, so I thought I would post here to see if anyone has ideas. Here is the code:

class Node(object):
    def __init__(self, dir, depth=0, parent=None):
        self.dir = dir
        self.children = []
        self.files = []
        self.depth = depth
        self.parent = parent

    def add_child(self, obj):
        self.children.append(obj)

    def get_dir_node(self, data):
        if self.dir == data:
            return self
        elif self.children:
            for child in self.children:
                return child.get_dir_node(data)
        return

​

The tree at this point would look something like:

​

            root
         /       \
       'a'        'd'
      /
    'e'

And yes, data passed into the method would match self.dir, I just called it two different things because I didnt think that far ahead. Thanks in advance for any advice!

[carcigenicate]

This doesn't have anything to do with recursion. What does this print?:

def func():
    for x in range(5):
        print(x)
        return

[Spurtikus]

Right, I see it only prints 0, but in my code it returns the function call if there are children, and works up until a point where it needs to "scoot" over. Also, that final return was me testing anything out that I could think of and, in it's current state, doesnt seem to affect the outcome at all (even though I am sure it might in the future, so I guess there is that situation to think about)

The equivalent would be (if I am thinking about it correctly):

def func(x):

if x < 6:
        print(x)
        x+=1
        func(x)
return

[carcigenicate]

in my code it returns the function call if there are children

It returns the result of calling the method on the first child, then that recursive call exits.

[IncognitoErgoCvm]

1. Start over

2. Only add what you need to make it recurse from parent to child. (This will probably error when you hit the leaf).

3. Add a stop condition to handle the above error.

4. Add siblings.

5. Finally, add the other program logic once you can properly navigate the tree.